Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing board config using server gui #76

Closed
adigyran opened this issue Nov 4, 2021 · 4 comments
Closed

Changing board config using server gui #76

adigyran opened this issue Nov 4, 2021 · 4 comments

Comments

@adigyran
Copy link
Member

adigyran commented Nov 4, 2021

Different approach of issue #75, would be having prebuild firmware and storing defines.h configs in flash with serial commands to change it. But there is a problem with board type, prebuilding for different hardware is not ideal.

@Eirenliel
Copy link
Member

No. Defines are defines, they shouldn't be changed. They define the hardware used. Things that should be in the config may be in the config, but defines are hardware-dependant.

@deiteris
Copy link
Member

deiteris commented Nov 6, 2021

Except defines.h also contains IMU_ROTATION and SECOND_IMU_ROTATION which have nothing to do with hardware and could configured on the server and stored either on server or MCU side.

The whole idea is to greatly simplify DIY approach. We don't necessarily need to keep all pinout in flash. We can automate building of IMU x BOARD firmwares that people could choose in the server with two selectors, upload like you proposed in #75 and be on their way without messing around with the code. If it's full custom approach, then follow the docs that currently explain how to do that manually, without bundling the server with unnecessary (even though, optional) stuff.

@ButterscotchV
Copy link
Member

I'd propose a separate application if you want something to build the firmware, building the firmware would be a niche function to have in the server and a lot of extra code to maintain.

@TheButlah
Copy link
Contributor

TheButlah commented Nov 14, 2021

why not just have the rotation be a variable instead of a constant? It can be DEFINEd to a default value, and the server can dynamically modify it via either post-processing on the quats, or by sending a command with the target rotation to the boards and store that in filesystem

I also agree that the ability to set the rotation in the server somewhere would be very nice. It helps for example when I want to rotate the side that the extension cable comes out of to be closer to the extension tracker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants