DistinctiveItem/isSimilar + Backpack canStack #3384
Conversation
|
|
||
| /** | ||
| * Implement this interface for any {@link SlimefunItem} to prevent | ||
| * cargo using only it's ID when comparing. #isSame is used when |
There was a problem hiding this comment.
Ah, quite right - thanks 👍
Line 280 is under discussion, and as the PR states, getItemData is in question also. On that note I should have made this draft |
|
So, near as I can tell, the 5th branch (line 280) is never called by items moving through cargo though it will be reached when directly calling isItemSimilar. Given that meta is required to check distinction this will could add a lot of overhead to any other machine using this. Given the above, do we still want to check distinction outside of cargo - given that we do not currently and it, in itself, hasn't shown issues. Input welcome for how to add this in. Also - changes in commit 92b45ad tested under the same conditions with expected and wanted results. |
|
if that's the case then i would say it's fine as is |
|
See #3417 |
Description
SlimefunItemStacks that share an ID are currently automatically stacked when running through cargo. Items that vary by lore or another meta aspect are being 'merged' with items that happen to match on ID but are, otherwise, distinct. See issue #3379. This likely only effects backpacks within core Slimefun but also effects any similar SlimefunItems using similar distinctions - DankPacks and Tinkers parts (I'm so self centred!) being an example.
Proposed changes
New
ItemAttributecalledDistinctiveItemto act as an identifier for items that match this criterion.Distinctive item has a method that allows an implementation to say how two same-ID items can be distinguished.
SlimefunBackpack has been amended to implement this interface.
SlimefunUtils#isItemSimilarnow checks if the stack's SlimefunItem is a DistinctiveItem and, if so, return the result of thecanStackmethod.Discussion with
Walshyshows this is making an extra call to get the ID from the Meta that was already made in the previousgetItemDatathat may mean this PR needs more work.Related Issues (if applicable)
Resolves #3379
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values