Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add item group key to item group items #4158

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: add item group key to item group items #4158

wants to merge 2 commits into from

Conversation

ybw0014
Copy link
Contributor

@ybw0014 ybw0014 commented Mar 3, 2024 •
edited
Loading

Description

ItemGroup items can be arbitrary. A Slimefun item, a simple renamed vanilla item, or a complex item can be an ItemGroup item.
It would be good if they could have their NamespacedKey in their PDC so other plugins can read this as an ItemGroup item.

Proposed changes

ItemGroup items now have slimefun:item_group in their PDC.

Related Issues (if applicable)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@ybw0014 ybw0014 requested a review from a team as a code owner March 3, 2024 15:12
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 3, 2024

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility
If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 3, 2024

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 08574465

https://preview-builds.walshy.dev/download/Slimefun/4158/08574465

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

WalshyDev
WalshyDev reviewed Mar 3, 2024
View reviewed changes
Copy link
Member

@WalshyDev WalshyDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the use case for the PDC here?

src/main/java/io/github/thebusybiscuit/slimefun4/api/items/ItemGroup.java
Comment on lines -217 to -221
String name = Slimefun.getLocalization().getItemGroupName(p, getKey());

if (name == null) {
name = item.getItemMeta().getDisplayName();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come this was changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getDisplayName has same logic with this piece of code, so I simplify it. if u don't like it I can revert this part.

@ybw0014
Copy link
Contributor Author

ybw0014 commented Mar 3, 2024

What's the use case for the PDC here?

For my addon SlimefunTranslation. Slimefun's localization only covers Slimefun's ItemGroups, it is a bit annoying to add localization for addons' ItemGroups. (unless I missed something)

@ybw0014 ybw0014 mentioned this pull request May 21, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalshyDev WalshyDev WalshyDev left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ybw0014 @WalshyDev