Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fix for issues #17 and #57 (decimal places for percentage filter and ignore +100 option #69

Merged
merged 11 commits into from
Jul 24, 2016

Conversation

ricardopetrere
Copy link
Collaborator

The last comment at issue #17 and issue #57 suggest two features:

  • The possibility to hide +100 from the Recommendations table (showing just unlocks and upgrades)
  • The possibility to specify a decimal value at the percentage filter (e. g. 3.8%), instead of just integers

Please see if this would suffice both :)

@Slimmmo
Copy link
Owner

Slimmmo commented Jul 23, 2016

Quick question, why is it a text field instead of a number field with a step of 0.1?

@ricardopetrere
Copy link
Collaborator Author

ricardopetrere commented Jul 23, 2016

I also asked that question myself (it was already this way hahaha)

I think it's this way so that it doesn't show those up/down arrows, like the x3 multipliers does (at least, when I changed "type" to number, it did that). To be more "UI pleasant", perhaps.

Besides, if it were a number field, there wouldn't be the need of those blue arrows controls, so it was made on purpose.

@Slimmmo
Copy link
Owner

Slimmmo commented Jul 24, 2016

Ah yeah that's right. I couldn't figure out how to hide the up/down arrows on all the browsers. Merging.

@Slimmmo Slimmmo merged commit ae60349 into Slimmmo:master Jul 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants