Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove certain stat and memory info to downscale scope #62

Open
SlyAceZeta opened this issue Sep 2, 2023 · 1 comment
Open

Remove certain stat and memory info to downscale scope #62

SlyAceZeta opened this issue Sep 2, 2023 · 1 comment
Assignees
@SlyAceZeta
Labels
low priority Other issues may take precedence over this one
Milestone
Code Overhaul

Comments

@SlyAceZeta
Copy link
Owner

This site isn't intended to be an online version of PKHeX; we don't need every possible data field a Pokemon can have. Removing some of the data fields can help downscale the site's scope so we can focus on improvements to what matters for this site.

In addition, the notes field exists specifically to allow players to write down whatever they want for each mon, including the following fields if so desired.

Consider removing the following for the respective reasons:

  • IVs: difficult for most people to calculate
  • EVs: easily changed at any time
  • Mint: easily changed at any time, difficult to discern/remember for traded or previously-minted mons
  • Ability: changes on a per-game basis as of HOME v3.0.0
  • Characteristic: Gen III/IV mistranslation makes this overly complicated, and without IVs, EVs, or Mint, this serves no purpose
@SlyAceZeta SlyAceZeta added the low priority Other issues may take precedence over this one label Sep 2, 2023
@SlyAceZeta SlyAceZeta self-assigned this Sep 2, 2023
@SlyAceZeta
Copy link
Owner Author

Reasons not to remove the following:

  • Met Date: Cannot be changed, and since Met Level is required for at least one or two Ribbons, we might as well keep Met Date to match
  • OT, ID, Nature: Cannot be changed, and without Characteristic these fields may be necessary to discern similar Pokemon from each other

@SlyAceZeta SlyAceZeta mentioned this issue Mar 4, 2023
Open
9 tasks
SlyAceZeta added a commit that referenced this issue Sep 3, 2023
@SlyAceZeta
consolidating data files
8944aca 
- removing abilities.js in preparation for #62 (no actual effect since it wasn't being used)
- bundling commonforms.js inside of misc.js to reduce number of files
@SlyAceZeta SlyAceZeta mentioned this issue Sep 3, 2023
Closed
@SlyAceZeta SlyAceZeta added this to the Redesign milestone Sep 10, 2023
SlyAceZeta added a commit that referenced this issue Sep 16, 2023
@SlyAceZeta
cleaning up misc data and adding new guides
8d437ad 
- added repeated messages section
- cleaned up natures: removed mint images, removed indices and reordered per index, and lowercased object names following other objects
- removed characteristics per #62
- added English guides for National and Earth Ribbons
SlyAceZeta added a commit that referenced this issue Mar 1, 2024
@SlyAceZeta
initial redesign commit
86684d1 
This code is still in an incomplete state and not production-ready, but I wanted to make sure my progress was saved on GitHub and not just my local machine. The goal is to have feature parity with the current version of the site before this goes live.

Incomplete features:
- Adding/editing/sorting/deleting Pokemon
- Adding/editing/sorting/deleting boxes
- Reflecting changes when restoring a backup
- Ribbon Checklist
- Filtering Pokemon list
- World Ability setting ( #46)
- Memory Ribbon setting ( #66 )
- Interface language support ( #20 )
- per-Pokemon disabling of auto Strange Ball setting ( #75 )

The site now uses Bootstrap as its base, which removes the need for jQuery Modal. Sortable and Workbox replace jQuery UI and UpUp, respectively. jQuery is updated to version 3.7.1.

This also works on the following issues:
- Pokemon are now displayed as "complete" when they have no more Ribbons to earn, closes #15
- A loading screen is displayed while JSON data is being retrieved, closes #25 as best as we can
- A condensed view is available, closes #40
- Pokemon names and titles display together and change their position depending on the language as well as whether the title has specific ordering (Partner Ribbon), closes #43
- new backup and restore format using valid JSON, this is the 3rd version and hopefully the last, closes #53
- Pokemon data is edited to separate Origin Marks from Origin Games, allowing for selecting a mark without a game, closes #60
- Total count of Ribbons is displayed in the cards, closes #61
- Pokemon data is edited to remove fields we will no longer track (reducing the storage size for users with many Pokemon), closes #62
- optional Gen III/IV/V origin marks are added, closes #69
SlyAceZeta added a commit that referenced this issue Mar 21, 2024
@SlyAceZeta
creating majority of add/edit Pokemon form
bbcb773 
- still plenty of TODOs in the select dropdowns, and there's no actual functionality yet, but this is just a stopping point for now
- all existing fields except those to be removed per #62 and except Ribbons, title, and scale check are in place
- added some game-specific achievements per #50
- added GMax toggle per #54 as well as Totem toggle
- added Pokerus options per #56
- added Met Location per #59
- separated the Origin Mark and Origin Game dropdowns per #60
- added per-Pokemon Strange Ball setting per #75
- removed setting to hide Square Shiny option since it would cause issues with currently-Square Shiny Pokemon having a blank Shiny section when editing; replaced with a help tooltip
- more minor changes to Memory Ribbon setting for mobile display
- removed Shiny Leaf icon
- renamed origin marks closer to their actual names
SlyAceZeta added a commit that referenced this issue Mar 26, 2024
@SlyAceZeta
preserving deprecated data in notes
5fe4884 
instead of outright deleting the data as #62 initially described, we can preserve it in each Pokemon's Notes field so no one loses anything they put into the current version of the website
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SlyAceZeta SlyAceZeta

Labels
low priority Other issues may take precedence over this one
Projects
None yet
Milestone
Code Overhaul
Development

No branches or pull requests
1 participant
@SlyAceZeta