reproducibility improvement #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
more options available from the command line more consistent way to implement the various filtering stages
this way we can go for more and more complex scenarios also the shortcut for --dry-run becomes more traditional -n
Sm00thix
added a commit
that referenced
this pull request
Jun 27, 2024
* Added support for estimation of benchmarking for sk, np1, and np2. Also modified paper/README.md to clarify the estimation process. Also updated the notebook to reflect the newly added --estimate flag in time_pls.py. This is related to #24 * reproducibility improvement (#30) * clarify the estimation methods * refactor the notebook for reproducing results more options available from the command line more consistent way to implement the various filtering stages * reproducing notebook: replace -s (bool) with -s <n> this way we can go for more and more complex scenarios also the shortcut for --dry-run becomes more traditional -n * Clarified instructions for manual benchmarking in paper/README.md. Related to #24 --------- Co-authored-by: parmentelat <thierry.parmentelat@inria.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the point here is twofold: