Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds remaining mandatory fields to Control #156

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Adds remaining mandatory fields to Control #156

merged 1 commit into from
Jun 16, 2022

Conversation

knotekt
Copy link
Collaborator

@knotekt knotekt commented Jun 16, 2022

Resolves #154

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #156 (1377d60) into master (ee52a91) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #156      +/-   ##
============================================
- Coverage     79.83%   79.74%   -0.10%     
  Complexity      625      625              
============================================
  Files            84       84              
  Lines          1701     1703       +2     
  Branches        137      137              
============================================
  Hits           1358     1358              
- Misses          267      269       +2     
  Partials         76       76              
Impacted Files Coverage Δ
src/main/java/cz/smarteon/loxone/app/Control.java 60.00% <0.00%> (-15.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee52a91...1377d60. Read the comment docs.

Copy link
Contributor

@jimirocks jimirocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job, pls remove reundand annotation

src/main/java/cz/smarteon/loxone/app/Control.java Outdated Show resolved Hide resolved
@jimirocks jimirocks merged commit 7f367b1 into Smarteon:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants