Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced the use of lombok for Control hierarchy, Category & Room #166

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

TCke83
Copy link
Contributor

@TCke83 TCke83 commented Aug 11, 2022

First version of lombok use

@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Merging #166 (f1358c2) into master (027fc30) will increase coverage by 0.18%.
The diff coverage is 75.00%.

❗ Current head f1358c2 differs from pull request most recent head 0dc7e2e. Consider uploading reports for the commit 0dc7e2e to get more accurate results

@@             Coverage Diff              @@
##             master     #166      +/-   ##
============================================
+ Coverage     80.22%   80.41%   +0.18%     
  Complexity      650      650              
============================================
  Files            86       86              
  Lines          1755     1751       -4     
  Branches        141      141              
============================================
  Hits           1408     1408              
+ Misses          271      266       -5     
- Partials         76       77       +1     
Impacted Files Coverage Δ
src/main/java/cz/smarteon/loxone/app/Category.java 75.00% <75.00%> (-25.00%) ⬇️
src/main/java/cz/smarteon/loxone/app/Control.java 66.66% <75.00%> (ø)
src/main/java/cz/smarteon/loxone/app/Room.java 75.00% <75.00%> (-25.00%) ⬇️
.../main/java/cz/smarteon/loxone/LoxoneWebSocket.java 67.69% <0.00%> (+2.65%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jimirocks jimirocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the lombok PoC. It looks good apart from losing the nullability marker annotations. As we use the library mostly from kotlin, I am not sure it is acceptable.

While introducing lombok brings some comfort for programmer it makes the library less safer to use. To me the safeness is something what should not be sacrified.

@jimirocks
Copy link
Contributor

The last thing - could you please additionally introduce nullability annotations to the Category and Room classes?

@jimirocks jimirocks added the enhancement New feature or request label Aug 12, 2022
@jimirocks jimirocks added this to the next milestone Aug 12, 2022
@jimirocks jimirocks merged commit 9b1bcd5 into Smarteon:master Aug 12, 2022
@TCke83 TCke83 deleted the lombok branch August 12, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants