Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added @EqualsAndHashCode to LoxoneUuid + small semantic fix in CommandResponseListener #173

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

TCke83
Copy link
Contributor

@TCke83 TCke83 commented Sep 12, 2022

Added @EqualsAndHashCode to LoxoneUuid + small semantic fix in CommandResponseListener

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Base: 79.01% // Head: 78.99% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (dec6996) compared to base (488ef81).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #173      +/-   ##
============================================
- Coverage     79.01%   78.99%   -0.02%     
+ Complexity      642      635       -7     
============================================
  Files            86       86              
  Lines          1768     1757      -11     
  Branches        148      144       -4     
============================================
- Hits           1397     1388       -9     
+ Misses          284      282       -2     
  Partials         87       87              
Impacted Files Coverage Δ
...va/cz/smarteon/loxone/CommandResponseListener.java 71.42% <ø> (ø)
src/main/java/cz/smarteon/loxone/LoxoneUuid.java 90.00% <100.00%> (-3.55%) ⬇️
.../main/java/cz/smarteon/loxone/LoxoneWebSocket.java 67.25% <0.00%> (+0.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jimirocks jimirocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for contribution!

@jimirocks jimirocks merged commit f4937b3 into Smarteon:master Sep 13, 2022
@jimirocks jimirocks added this to the next milestone Sep 13, 2022
@jimirocks jimirocks added the enhancement New feature or request label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants