-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Boost.Beast agent with callback interface. #18
Conversation
To disambiguate calls to API methods without real arguments (like log_out()) those methods now don't have empty args param.
c6aa60f
to
eb5e112
Compare
eb5e112
to
aca058f
Compare
Thank you for such a big PR!
It would be great, if you implement fix described in the first point (at least), so I'll accept this PR. If not, I can also accept it and make this changes myself. P.S. I apologize for not responding for a long time (was on vacation) |
I agree: impossibility to ignore result is annoying. But I think, if we merge
Sorry, but I don't understand. How callback-based interface can be non-monadic? |
Agreed.
I can't imagine it too, that's why I mentioned this as a problem :) |
Renames: make_future -> make_async beast_future_monadic -> beast_async_monadic beast_future -> beast_async
Done. Hope nothing will break.
I think you better do this by yourself. :) |
Merged. Thanks for your contribution! 🎉 |
This PR implements second part of #2 for Boost.Beast agent.
To disambiguate calls to API methods without real arguments (like log_out()) those methods now don't have empty args param.
Technically, it is a breaking change, but only for users, who explicitly pass empty args to those methods (maybe, nobody).
I made this PR for personal project, but hope it will be helpful. :)