New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade pyroscope-go for Go 1.22 build support #101

Merged

SmilyOrg merged 1 commit into SmilyOrg:main from Terrance-forks:go-1.22-build

Feb 24, 2024

Contributor

Terrance commented Feb 24, 2024

Building with Go 1.22, I'm getting the following error:

# github.com/grafana/pyroscope-go/godeltaprof/internal/pprof
../../go/pkg/mod/github.com/grafana/pyroscope-go/godeltaprof@v0.1.4/internal/pprof/delta_mutex.go:25:20: undefined: runtime_cyclesPerSecond
../../go/pkg/mod/github.com/grafana/pyroscope-go/godeltaprof@v0.1.4/internal/pprof/proto.go:400:8: undefined: runtime_expandFinalInlineFrame

Looks like godeltaprof has an upper Go build version which has since been increased: grafana/pyroscope-go@1c04c88

This PR bumps godeltaprof v0.1.4→v0.1.6 via pyroscope-go v1.0.4→v1.1.0.


          Upgrade pyroscope-go for Go 1.22 build support

681dcd4

Owner

SmilyOrg commented Feb 24, 2024

Thanks!

SmilyOrg merged commit 73fca6d into SmilyOrg:main

1 check passed

Terrance deleted the go-1.22-build branch

February 24, 2024 13:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet