Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WSL2 physical ports for esptool #2791

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Conversation

mikee47
Copy link
Contributor

@mikee47 mikee47 commented Jun 6, 2024

Further to #2790 esptool of course uses COM ports and same issue applies when physical ports available in WSL2.

Copy link

what-the-diff bot commented Jun 6, 2024

PR Summary

  • Adjustment of Condition in esptool
    The condition set to execute a certain block of code in the esptool component was modified. This means that instead of looking for if a specific setting (WSL_ROOT) is defined or not, the code will now check if the new setting (WSL_COMPORT_POWERSHELL) is equal to 1. This change will allow better control over when certain sections of the code are executed, enhancing the functionality and efficiency of the tool.

@slaff slaff added this to the 5.2.0 milestone Jun 7, 2024
@slaff slaff merged commit 7e11439 into SmingHub:develop Jun 7, 2024
38 checks passed
@mikee47 mikee47 deleted the fix/wsl2-serial branch June 7, 2024 14:13
@slaff slaff mentioned this pull request Jul 4, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants