Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if CI issues are due to parallel runs of LWIP2 on Windows. #2815

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

slaff
Copy link
Contributor

@slaff slaff commented Jun 18, 2024

No description provided.

@mikee47
Copy link
Contributor

mikee47 commented Jun 18, 2024

UPDATE: Not applicable, patch has changed with different commit. Ignore.

I've done a side-by-side comparison of the raw logs from this and a failed build and found the problem. This is from the successful run:

Fetching submodule 'lwip' ...
Submodule 'lwip' (https://github.com/lwip-tcpip/lwip) registered for path 'lwip'
Cloning into 'D:/a/Sming/Sming/Sming/Components/lwip/lwip'...
Submodule path 'lwip': checked out 'e8741da9d2086c0fad6703536e1c6133b8f88512'
Checking patch contrib/ports/unix/port/sys_arch.c...
Checking patch contrib/ports/CMakeCommon.cmake...
Checking patch contrib/ports/win32/sys_arch.c...
Checking patch contrib/ports/win32/pcapif.c...
Checking patch contrib/ports/win32/pcapif_helper.c...
Applied patch contrib/ports/unix/port/sys_arch.c cleanly.
Applied patch contrib/ports/CMakeCommon.cmake cleanly.
Applied patch contrib/ports/win32/sys_arch.c cleanly.
Applied patch contrib/ports/win32/pcapif.c cleanly.
Applied patch contrib/ports/win32/pcapif_helper.c cleanly.

and the failed run:

Fetching submodule 'lwip' ...
Submodule 'lwip' (https://github.com/lwip-tcpip/lwip) registered for path 'lwip'
Cloning into 'D:/a/Sming/Sming/Sming/Components/lwip/lwip'...
Submodule path 'lwip': checked out '86c9f7999150199374d7697fd2eed62dcd9b1afa'
Checking patch contrib/ports/unix/port/sys_arch.c...
Checking patch contrib/ports/CMakeCommon.cmake...
Checking patch contrib/ports/win32/sys_arch.c...
Checking patch contrib/ports/win32/pcapif.c...
Applied patch contrib/ports/unix/port/sys_arch.c cleanly.
Applied patch contrib/ports/CMakeCommon.cmake cleanly.
Applied patch contrib/ports/win32/sys_arch.c cleanly.
Applied patch contrib/ports/win32/pcapif.c cleanly.

@mikee47
Copy link
Contributor

mikee47 commented Jun 18, 2024

Actually that failed run is from the new lwip version, ignore.

@slaff
Copy link
Contributor Author

slaff commented Jun 18, 2024

I will run this PR three times and if all is ok I will merge it as it is. I know it is not the best solution but better a workaround than having to run manually failed jobs.

@slaff slaff added this to the 5.2.0 milestone Jun 18, 2024
@slaff slaff changed the title [WIP] Check if CI issues are due to parallel runs of LWIP2 on Windows. Check if CI issues are due to parallel runs of LWIP2 on Windows. Jun 18, 2024
@mikee47
Copy link
Contributor

mikee47 commented Jun 18, 2024

I will run this PR three times and if all is ok I will merge it as it is. I know it is not the best solution but better a workaround than having to run manually failed jobs.

I'm doing the same check but focussed on just the lwip2 component. If it works I'll open a PR.

@slaff slaff merged commit 9a3c9a7 into SmingHub:develop Jun 18, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants