Update ESP32 BLE libraries, apply fixes #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch fixes for warnings Hide unused parameter warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the three ESP32 BLE libraries and applies some fixes.
esp-nimble-cppsubmodule)ESP32-BLE-Gamepadsubmodule)ESP32-BLE-Keyboardsubmodule)There are some
unused parameterwarnings present (when enabled) which can mask issues. Disabled those warnings for library build (in component.mk) and fixed them so #include files don't cause issues elsewhere. Many warnings come from idf.Fixed in ESP32-BLE-Gamepad:
ISO C++ forbids converting a string constant to 'char*' [-Wwrite-strings]. No reason for these not to beconst char*. Patched.BleConnectionStatus.h 'virtual void NimBLEServerCallbacks::onDisconnect(NimBLEServer*, NimBLEConnInfo&, int)' was hidden [-Woverloaded-virtual=]. Fixed method implementation, addedoverridedirective.