Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: some cleaning & fix rotated iou distance #34

Merged
merged 5 commits into from
Jan 14, 2024
Merged

Conversation

Smirkey
Copy link
Owner

@Smirkey Smirkey commented Jan 14, 2024

No description provided.

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (1c86706) 98.87% compared to head (c116d3c) 98.64%.

Files Patch % Lines
powerboxesrs/src/rotation.rs 94.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   98.87%   98.64%   -0.23%     
==========================================
  Files          15       15              
  Lines        2303     2364      +61     
==========================================
+ Hits         2277     2332      +55     
- Misses         26       32       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 14, 2024

CodSpeed Performance Report

Merging #34 will degrade performances by 94.06%

Comparing improvements (c116d3c) with main (1c86706)

Summary

❌ 1 regressions
✅ 144 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main improvements Change
test_rotated_iou_distance[float64] 6.9 ms 116.1 ms -94.06%

@Smirkey Smirkey changed the title refactor: some cleaning refactor: some cleaning & fix rotated iou distance Jan 14, 2024
@Smirkey Smirkey merged commit e500cba into main Jan 14, 2024
20 of 22 checks passed
@Smirkey Smirkey deleted the improvements branch January 14, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant