Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use rtree in rotated box iou #36

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

Smirkey
Copy link
Owner

@Smirkey Smirkey commented Jan 15, 2024

Use rtree to avoid expensive iou computation

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e500cba) 98.64% compared to head (287a571) 98.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   98.64%   98.67%   +0.03%     
==========================================
  Files          15       15              
  Lines        2364     2418      +54     
==========================================
+ Hits         2332     2386      +54     
  Misses         32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 15, 2024

CodSpeed Performance Report

Merging #36 will improve performances by 50.95%

Comparing speedup/rotated_iou (287a571) with main (e500cba)

Summary

⚡ 1 improvements
✅ 144 untouched benchmarks

Benchmarks breakdown

Benchmark main speedup/rotated_iou Change
test_rotated_iou_distance[float64] 116.2 ms 77 ms +50.95%

@Smirkey Smirkey marked this pull request as ready for review January 15, 2024 20:41
@Smirkey Smirkey merged commit 4dc5b2c into main Jan 15, 2024
25 checks passed
@Smirkey Smirkey deleted the speedup/rotated_iou branch January 15, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant