keyboard: use SmallVec for the Enter event's currently pressed keys #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Event enum used string slices referencing stack-allocated Vecs (that were not reused anywhere else).
The lifetime makes it awkward for consumers (no way to e.g. store the Event somewhere) but I doubt
that it was a useful optimization (even if the optimizer can't allocate the Vec directly in the resulting enum,
creating a slice of it is hardly better than moving it: you still write the address and size, just not the capacity).
However, we can use SmallVec (already a dependency of wayland-rs) for an actual optimization:
this will avoid allocating Vec contents if 1-2 keys are held when the surface gets keyboard focus.
Unfortunately this does change the public API (e.g.
winit
would need to drop a<'_>
) — it's possible to add aPhantomData
for the lifetime though, but accumulating backwards compat junk on 0.x versions is ehh :/