Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework for wayland-rs 0.30 #215

Merged
merged 130 commits into from
Jul 17, 2022
Merged

Rework for wayland-rs 0.30 #215

merged 130 commits into from
Jul 17, 2022

Conversation

elinorbgr
Copy link
Member

@elinorbgr elinorbgr commented Jan 5, 2022 •
edited by i509VCB
Loading

Roadmap from i5 for 0.30:

@elinorbgr elinorbgr mentioned this pull request Jan 5, 2022
Closed
@elinorbgr elinorbgr mentioned this pull request Mar 6, 2022
Closed
22 tasks
@i509VCB
Copy link
Member

i509VCB commented Mar 23, 2022 •
edited
Loading

Just going to note here to keep this idea in our minds.

Do we want to offer a sort of "super delegate type" for desktop like the environment desktop preset in 0.29 era sctk.

One way this could be represented using a sort of DesktopState type which itself contains multiple delegate types (compositor, xdg shell, output, seat) and a single macro to delegate to that group of delegate types.

You would still need to implement some traits but it would make some very common groups of protocols easily usable.

@i509VCB
Copy link
Member

i509VCB commented Apr 15, 2022

Do we want to consider more types of shm pools.

A double buffered pool is already essentially guaranteed to be implemented

There are some other possible useful pools implementations I can think of:

  • SinglePool (name needs bikeshed) - A single shm buffer, meant for maximum control with race free access to the underlying content. This may be useful in very specific scenarios. This would not be implemented using a MultiPool as to reduce the overhead as much as possible.
  • SwapchainPool (with name bikeshed) - Acts like a swapchain with N-buffering. This might be hard to justify since you would struggle to use the buffers faster than the server renders to the screen unless very aggressive damage tracking is used. Resizes could balloon really quickly due to the shear number of buffers. Might be useful for high refresh rate displays.

@elinorbgr
Copy link
Member Author

Overall, I think those additional pools should not be considered as blocking the 0.30 update, and can be added after the merge.

@LGFae LGFae mentioned this pull request Apr 30, 2022
Closed
@elinorbgr elinorbgr mentioned this pull request Jun 1, 2022
Merged
@i509VCB
Nuke existing SCTK codebase
1ae9ec6
@i509VCB
Nuke existing SCTK codebase.
95113a1 
0.30 is a complete rewrite pretty much.
@i509VCB
WIP: output management
22b814f
@i509VCB
WIP example for outputs
ae2c61f
@i509VCB
rebase output
841582d
@i509VCB
WIP wl_shm
1042571
@i509VCB
WIP: RawPool
de6f4f1
@i509VCB
registry: initial concept
dca6ec9
@i509VCB
move output example to use registry helpers
eb0e374
@i509VCB
rework shm to use registry helpers
42a7cdf
@i509VCB
WIP: xdg shell
eaba4f2
@i509VCB
WIP: xdg shell
3507215
@i509VCB
wip: xdg shell pt 2
30f4a36
@i509VCB
yeet DataInit
3aa1fbe
@i509VCB
fix calculation error for x and y for drawing
339ca72
@i509VCB
fix dumb mistake
c13223e
@i509VCB
shm: remove handler trait and expose function for formats
43df85f
@i509VCB
shm: convience macro
d444beb
@i509VCB
shm and registry delegate macros
fadd09a
@i509VCB
doc typos
4cc7903
@i509VCB
ex-simple_window: move to delegate_registry macro
fc85581
@i509VCB
raw pool changes and moving things around windowing
285ec9d
snakedye and others added 26 commits July 16, 2022 21:42
@snakedye @i509VCB
Remove format and use an alignment of 64 for the multipool
a2382c0
@snakedye @i509VCB
Align the slotpool buffers to 64
8e8129d
@snakedye @i509VCB
Correct (try) alignment in slotpool
e64f3e8
@snakedye @i509VCB
Remove mut on offset
f3a6c0a
@snakedye @i509VCB
Rewrite len
b163f38
@snakedye @i509VCB
replace "size += size % 64; size -= size % 64;"
8fe5a24
@snakedye @i509VCB
Destroy the buffer when the BufferSlot is dropped.
cfb7eb0
@snakedye @i509VCB
Add From implementation to ShmState
5de0c0d
@danieldg @i509VCB
Remove xdg::ConfigureHandler
361e320 
Configuration is handled by the role-specific object that created the
surface via Dispatch<XdgSurface, {Window,Popup}Data>.
@danieldg @i509VCB
Add xdg::popup implementation
61ef751
@danieldg @i509VCB
Update maximum versions of bound objects
24ece0c
@danieldg @i509VCB
Add ProvidesBoundGlobal trait
4b43956
@danieldg @i509VCB
Add a SimpleGlobal struct
ab2993c
@danieldg @i509VCB
Fix formatting
be6233d
@danieldg @i509VCB
Bump minimum rustc to 1.61
c958c49
@danieldg @i509VCB
Add XdgPositioner
fbfeedf
@danieldg @i509VCB
Convert users of XdgShellState to ProvidesBoundGlobal
3e1033e
@danieldg @i509VCB
Broadcast output scale changes to surfaces
798633f
@danieldg @i509VCB
Change unused Userdata from () to GlobalData
e2f5635 
This avoids potentially generating colliding impl Delegate blocks.
@danieldg @i509VCB
Add a WlRegion wrapper
d09a64f
@danieldg @i509VCB
Add a WlSurface wrapper
3583725
@danieldg @i509VCB
Convert XdgShellSurface to use compositor::Surface
7d9135b 
This correctly destroys the surface if construction of the
XdgShellSurface fails and allows transferring ownership from an existing
owned WlSurface.
@snakedye @i509VCB
Make GlobalData fully public
dfc012a
@snakedye @i509VCB
Remove () from GlobalData
7f8d8e4
@snakedye @i509VCB
fmt
3d26e26
@i509VCB
update beta.8 release
ed8e21b
@i509VCB i509VCB marked this pull request as ready for review July 17, 2022 02:51
i509VCB
i509VCB approved these changes Jul 17, 2022
View reviewed changes
Copy link
Member

@i509VCB i509VCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch is being merged into master. All pending issues will have issues created and added to a milestone group.

@i509VCB i509VCB merged commit 3f8dc7c into master Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i509VCB i509VCB i509VCB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@elinorbgr @i509VCB @chrisduerr @danieldg @zeroeightysix @snakedye