fix: offscreen texture has_alpha determination #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlesTexture::from_raw takes an `opaque` parameter. When creating an offscreen texture this parameter was set to `has_alpha` which would imply transparency, I.E. the opposite of opaque.
gsrushton
force-pushed
the
offscreen-texture-opaque-fix
branch
from
0b06821
to
920e843
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1058 +/- ##
=======================================
Coverage 24.20% 24.20%
=======================================
Files 140 140
Lines 22334 22334
=======================================
Hits 5405 5405
Misses 16929 16929
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GlesTexture::from_raw takes an
opaqueparameter. When creating an offscreen texture this parameter was set tohas_alphawhich would imply transparency, I.E. the opposite of opaque.