Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadlock in blocking_dispatch #695

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Conversation

jleedev
Copy link
Contributor

@jleedev jleedev commented Jan 25, 2024

If dispatch_inner_queue dispatches some events, blocking_dispatch will still wait for some events to come in, rather than turning the loop again and checking its done variable. This is causing Alacritty 0.13 to hang on startup.

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d5e7df) 75.34% compared to head (fe5d265) 75.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #695      +/-   ##
==========================================
- Coverage   75.34%   75.34%   -0.01%     
==========================================
  Files          48       48              
  Lines        8258     8257       -1     
==========================================
- Hits         6222     6221       -1     
  Misses       2036     2036              
Flag Coverage Δ
main 58.37% <0.00%> (+0.01%) ⬆️
test-- 81.08% <100.00%> (-0.01%) ⬇️
test--server_system 64.50% <100.00%> (-0.01%) ⬇️
test-client_system- 72.15% <100.00%> (-0.01%) ⬇️
test-client_system-server_system 54.82% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elinorbgr elinorbgr merged commit 3d73796 into Smithay:master Jan 29, 2024
14 checks passed
@jleedev jleedev deleted the patch-1-1 branch January 29, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants