Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more gpr datasets #2 #14

Merged
merged 7 commits into from
Jul 7, 2022
Merged

Add more gpr datasets #2 #14

merged 7 commits into from
Jul 7, 2022

Conversation

micahjohnson150
Copy link
Member

@micahjohnson150 micahjohnson150 commented Jul 7, 2022

  • Working on Add other GPR datasets #2
  • Pretty easy add-in. Added some functionality for new datetimes and different header column naming.
  • Also added some out of scope formatting on large numbers in the logs for readability.

@micahjohnson150
Copy link
Member Author

Looking for confirmation on kwargs specifically the observers and instrument names. Note in add_unm_gpr.py I am attempting to upload two chunks at a time, splitting on the two frequencies. I am assuming this a separate instrument so in my loop I am modifying the instrument between Mala 800MHz GPR and Mala 1600 MHz GPR

@4rwebb
Copy link

4rwebb commented Jul 7, 2022

Yes, the two frequencies are separate instruments that were run simultaneously from the same sled. There will be some overlap of the data, but if I could process and see a reflection with the 1600 MHz antenna then I would not look at the 800 MHz as the 1600 has better precision for the twt data.

@4rwebb
Copy link

4rwebb commented Jul 7, 2022

I looked very briefly, but the code looks good at first glance. I'll try to make some time to actually pull/plot the data to make sure it looks like it should.

@micahjohnson150
Copy link
Member Author

Cool! You wont be able to find this on the main db yet. I added it to a local copy I have for testing. I still need to sort out some of the details around the 2 Mala instruments and then I will merge it and add it to the DB. I will keep you posted.

@4rwebb
Copy link

4rwebb commented Jul 7, 2022 via email

@micahjohnson150
Copy link
Member Author

Ah I see. Well the uploader class I am using is pretty structured around a single instrument for a dataset. So I will just pivot the data on the frequency preemptively and upload them both as two datasets with the same DOI. The end use would allow for grabbing/filtering the db to the 800 when the 1600 is not available.

@4rwebb
Copy link

4rwebb commented Jul 7, 2022 via email

@micahjohnson150 micahjohnson150 merged commit 0578b83 into main Jul 7, 2022
@micahjohnson150 micahjohnson150 deleted the add_more_gpr_datasets_#2 branch July 7, 2022 19:37
@micahjohnson150
Copy link
Member Author

uploaded! Let me know if you have any issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants