Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Django 2 and Python 3 support #117

Merged
merged 21 commits into from
Jul 1, 2019
Merged

Django 2 and Python 3 support #117

merged 21 commits into from
Jul 1, 2019

Conversation

rnegron
Copy link
Contributor

@rnegron rnegron commented Jun 22, 2019 •
edited

General Changelog

Added

  • Python 3.7 support
  • Django 2.2 support
  • Pipenv support

Changed

  • Updated most packages to latest version
  • Replaced pycrypto with pycryptodome
  • Use Django's built-in libmemcached instead of third-party
  • Replaced django-states with django-fsm
  • Alter code to be Python 3 and Django 2 compliant
  • Adopt black code style

@rnegron
Update travis, dockerfile files, add Pipfile
d24bca7
@rnegron
Add on_delete kwarg, change reverse_lazy import path, change gettext …
923b69e 
…function
@rnegron
Update middleware, is_authenticated now a property
d2bef71
@rnegron
Blacken, isort, update some urls, update string formatting, remove un…
0a6284a 
…used files, update state machine to use django-fsm, remove unused middleware, update many packages, remove others, and more...
@rnegron
Fix all tests, remove unicode and six, fix translation proxy bug, fix…
dfa6184 
… state enum implementation
@rnegron
Move to Pipfile
105510f
@rnegron
Use Pipenv in Travis
8ce00fd
@rnegron
Add AlterField migration, squash file to Meetings
38ff35d
@rnegron
Remove Vagrantfile support
1bb3c4b
@rnegron
Remove pylibmc, Fabric and unidecode, fix settings
230ef16
@rnegron
Move to .env based configs, update readmes
bba82b5
@rnegron
Update Docker related files, blacken migrations
eff6d57
@rnegron
Fix TagWidget renderer bug
38467d6
@rnegron
Add sqlite3 testdb to Testing configuration
7ab4dd3
@rnegron
Update Django from 2.0 to 2.2
786c3e8
@rnegron
Remove unused commands, add pipenv check to travis
2334fe8
@rnegron
Update newrelic, Collectast, gunicorn, Django, replace old pycrypto w…
2544288 
…ith newer pycryptodome
@rnegron
Make Pipenv check ignore Travis' outdated numpy
97d3a8b
@rnegron
Copy link
Contributor Author

rnegron commented Jun 30, 2019 •
edited

Replacing django-states (no support for Python 3) with django-fsm is tricky... Opted to modify migration file, and include a squashed migration... Easiest solution is obviously to delete/overwrite existing meeting data.

Any better ideas?

@rnegron rnegron marked this pull request as ready for review June 30, 2019 16:33
@gcollazo
Copy link
Contributor

gcollazo commented Jul 1, 2019

@rnegron tienes deploy rights en Heroku. Be my guest.

@rnegron rnegron merged commit ecd0897 into master Jul 1, 2019
@rnegron rnegron deleted the django-2-and-python-3 branch July 1, 2019 23:08
@rnegron rnegron mentioned this pull request Jul 3, 2019
Closed
@rnegron rnegron mentioned this pull request Jul 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froi froi Awaiting requested review from froi

@jpadilla jpadilla Awaiting requested review from jpadilla

@gcollazo gcollazo Awaiting requested review from gcollazo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnegron @gcollazo