-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to clean Pipfile #116
Conversation
- pip install flake8 isort | ||
- pipenv install --dev | ||
script: | ||
- flake8 horas --ignore=E501 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be pipenv run flake8 horas --ignore=E501
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore this
- pip install flake8 isort | ||
- pipenv install --dev | ||
script: | ||
- flake8 horas --ignore=E501 | ||
- isort --recursive --check-only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be pipenv run isort --recursive --check-only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Pending the fixes needed for the failing test I don't see why not to merge.
Superseded by #117 |
The app runs in dev mode, needs further testing.