Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to clean Pipfile #116

Closed
wants to merge 2 commits into from
Closed

Conversation

gcollazo
Copy link
Contributor

@gcollazo gcollazo commented Jul 19, 2018

The app runs in dev mode, needs further testing.

@gcollazo gcollazo requested review from jpadilla and froi July 19, 2018 21:45
- pip install flake8 isort
- pipenv install --dev
script:
- flake8 horas --ignore=E501
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be pipenv run flake8 horas --ignore=E501

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore this

- pip install flake8 isort
- pipenv install --dev
script:
- flake8 horas --ignore=E501
- isort --recursive --check-only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be pipenv run isort --recursive --check-only

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore this

Copy link
Member

@froi froi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Pending the fixes needed for the failing test I don't see why not to merge.

@rnegron
Copy link
Contributor

rnegron commented Jul 3, 2019

Superseded by #117

@rnegron rnegron closed this Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants