fix/mini-tracking (#255)

* fix * made
SoapboxSocial · Apr 6, 2021 · 80765dc · 80765dc
1 parent deeab04
commit 80765dc
Show file tree

Hide file tree

Showing 4 changed files with 44 additions and 29 deletions.
diff --git a/pkg/pubsub/events.go b/pkg/pubsub/events.go
@@ -177,7 +177,7 @@ func NewRoomLinkShareEvent(user int, room string) Event {
 	}
 }
 
-func NewRoomOpenMiniEvent(user int, mini, room string) Event {
+func NewRoomOpenMiniEvent(user, mini int, room string) Event {
 	return Event{
 		Type:   EventTypeRoomOpenMini,
 		Params: map[string]interface{}{"id": user, "mini": mini, "room": room},

diff --git a/pkg/rooms/pb/room.pb.go b/pkg/rooms/pb/room.pb.go
diff --git a/pkg/rooms/room.go b/pkg/rooms/room.go
@@ -699,7 +699,7 @@ func (r *Room) onOpenMini(from int, mini *pb.Command_OpenMini) {
 
 	_ = r.queue.Publish(
 		pubsub.RoomTopic,
-		pubsub.NewRoomOpenMiniEvent(from, mini.Mini, r.id),
+		pubsub.NewRoomOpenMiniEvent(from, int(mini.Id), r.id),
 	)
 
 	resp, err := r.getMini(mini)

diff --git a/pkg/tracking/trackers/mixpaneltracker.go b/pkg/tracking/trackers/mixpaneltracker.go
@@ -220,12 +220,17 @@ func transform(event *pubsub.Event) *tracking.Event {
 			return nil
 		}
 
+		mini, err := event.GetInt("mini")
+		if err != nil {
+			return nil
+		}
+
 		return &tracking.Event{
 			ID:   strconv.Itoa(id),
 			Name: "room_open_mini",
 			Properties: map[string]interface{}{
 				"room_id": event.Params["room"],
-				"mini":    event.Params["mini"],
+				"mini":    mini,
 			},
 		}
 	case pubsub.EventTypeRoomLinkShare: