Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we add the "department" attribute to the azure provider's mapped fields? #1223

Closed
PaddingtonBrown opened this issue Jun 28, 2024 · 8 comments · Fixed by #1228
Closed

Can we add the "department" attribute to the azure provider's mapped fields? #1223

PaddingtonBrown opened this issue Jun 28, 2024 · 8 comments · Fixed by #1228

Comments

@PaddingtonBrown
Copy link
Contributor

Relates to #745
@PaddingtonBrown
Copy link
Contributor Author

In azure provider

Providers/src/Azure/Provider.php

Line 4 in 1cf2b81

PaddingtonBrown added a commit to PaddingtonBrown/Providers that referenced this issue Jun 28, 2024
@PaddingtonBrown
SocialiteProviders#1223 Add a list of fields to query for the user in…
7a9d28e 
…cluding department
@PaddingtonBrown
Copy link
Contributor Author

#1224

@PaddingtonBrown PaddingtonBrown mentioned this issue Jun 28, 2024
Closed
@atymic
Copy link
Member

atymic commented Jun 30, 2024

@PaddingtonBrown is there a reason why you can't use the microsoft provider? We are aiming to merge them soon.

@PaddingtonBrown
Copy link
Contributor Author

PaddingtonBrown commented Jul 1, 2024 •
edited
Loading

@atymic the microsoft provider doesn't have the department field too. I would/could add it to that provider too.

I used azure because the documentation said it was aimed at private azure logins accounts rather than public ones that the microsoft provider was aimed at.

@atymic
Copy link
Member

atymic commented Jul 1, 2024

Please PR it there :)

PaddingtonBrown added a commit to PaddingtonBrown/Providers that referenced this issue Jul 1, 2024
@PaddingtonBrown
SocialiteProviders#1223 Add department to the list of fields returned…
05abed3 
… in the microsoft provider
@PaddingtonBrown PaddingtonBrown mentioned this issue Jul 1, 2024
Merged
@PaddingtonBrown
Copy link
Contributor Author

@atymic here is a new pull request for the change #1228

atymic pushed a commit that referenced this issue Jul 2, 2024
@PaddingtonBrown
#1223 Add department to the list of fields returned in the microsoft …
a39b078 
…provider (#1228)
@PaddingtonBrown
Copy link
Contributor Author

Hi @atymic at what point will this get released as a new package version on packagist? Cheers

@atymic
Copy link
Member

atymic commented Jul 2, 2024

Tagged sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@PaddingtonBrown @atymic