[Build] Cleanup Makefile rules, comments. No new features. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the programs with LOC enabled (i.e. generated files mode), ensure that the generated loc_filenames.c is the 1st file in the list-of-sources defined for each binary being built. Otherwise, depending on `make` rules, we may end-up compiling one of the test-sources before the loc.h fileis generated. This results in using LOC-ELF mode of LOC-ID, which causes the link step to fail. this commit resolves this issue by consistently applying the rule that, e.g., SINGLE_FILE_CC_PROGRAM_GENSRC, is listed as the 1st item in SINGLE_FILE_CC_PROGRAM_TESTSRC . And, so on for other program binaries.
gapisback
force-pushed
the
gapisback/Fix-LOC-ELF-cpp.v5
branch
from
99fdcd5
to
fc76a4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit cleans-up some code ordering and comments in Makefile. No functionality is added / changed.