Some flatpak fixing #5510

powpingdone · 2024-05-30T22:01:08Z

This is a smaller PR to attempt to address future flathub reviews. As of May 30, 1700 CST, I haven't filed the issue to flathub yet, but it will happen in the future. This is just heading off future issues.

SoftFever · 2024-06-03T13:43:51Z

@powpingdone

Looks the flatpak build is broken for a while.
Do you have any idea what's wrong?

powpingdone · 2024-06-03T13:48:22Z

@SoftFever possibly that open cascade isn't being downloaded during the flatpak build

powpingdone · 2024-06-03T16:02:19Z

@SoftFever no wait, it's running out of space again

cochcoder · 2024-06-03T16:33:34Z

@SoftFever no wait, it's running out of space again

Does that also equate to the error I'm getting: Build failed: Error: The process '/usr/bin/xvfb-run' failed with exit code 1? I've noticed that the flatpak has the best chance to build on the first GitHub action when I start an entirely new PR.

powpingdone · 2024-06-03T16:39:41Z

@cochcoder yes

powpingdone · 2024-06-03T16:40:18Z

though, to be more specific, the xvfb-run executable is just a general running thing

cochcoder · 2024-06-03T16:45:18Z

I see, could it be a issue where the flatpak isn't deleting enough stuff for its second, and so on, runs?

powpingdone · 2024-06-03T16:46:00Z

It's possibly the CCACHE.

cochcoder · 2024-06-03T16:51:29Z

Hopefully its that, it would suck if it means no more ~20 minute builds, but its much better to have a flatpak rather than nothing. Currently having a flapak version is the only way for me, and others, to run Orca Slicer reliably.

powpingdone · 2024-06-05T16:01:20Z

Yeah coch, I really, really, really don't like the appimage. I just wish I had more time to work on this.

cochcoder · 2024-06-05T16:09:43Z

You've already done incredible work so far with the initial support. Even if this doesn't get worked on for a while, at least the majority, and I imagine the hardest, part is done.

powpingdone · 2024-06-06T05:41:22Z

This should be good now that caching is disabled. THOUGH, this means that the flatpak will take significantly longer to build.

powpingdone · 2024-06-06T16:48:24Z

@SoftFever Changes:

Disabled CI caching for the Flatpak
Included some missing includes to allow compilation
Fixed the commit between orcaslicer and it's fork of wx, for consistency in building.

powpingdone · 2024-06-17T12:48:43Z

...A few more changes, apparently: @SoftFever

OCCT was building Doxygen docs. A constexpr for whatever reason caused a compile error, so just disabling it outright fixed it and probably reduced the size of the build too.
Another missing include.
The base image got updated, which (I think) removed a few python dependencies for the orcaslicer init script, so I added them back.

powpingdone · 2024-06-17T22:34:08Z

@cochcoder upstream change

cochcoder · 2024-06-18T15:22:59Z

@cochcoder tl;dr: getting a blessing (api keys) from flathub

Even to upload to GitHub actions as an artifact?

powpingdone · 2024-06-18T16:39:25Z

No, that should just be in the CI job.

cochcoder · 2024-06-18T16:54:24Z

No, that should just be in the CI job.

Strange, maybe they're using the same name...

Edit: Seems that's it

AlessioMagni · 2024-06-18T19:47:07Z

i'm trying to build it in fedora silverblue 40 and encountering this error

error: metadata-generation-failed

_× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.
Error: module python-setuptools_scm: Child process exited with code 1_

i'm really new to this things so i probably did something wrong, if not hope that helps

powpingdone · 2024-06-19T15:22:06Z

@AlessioMagni make sure you're using this branch and building with it. I applied a fix for that in here.

cochcoder · 2024-06-19T15:22:11Z

Thought that I would put this out there in case this information is helpful in the future. When I enable caching I find that it gets stuck on adding printer covers in ~20 mins and then silently crashes before saying it succeeded with no artifact.

powpingdone · 2024-06-28T23:03:16Z

@SoftFever bump

cochcoder · 2024-07-01T05:39:01Z

I've done a few builds recently and found that the flatpak build was consistently getting this error and stopping:

make[1]: *** [CMakeFiles/Makefile2:1204: src/slic3r/CMakeFiles/libslic3r_gui.dir/all] Error 2
make: *** [Makefile:166: all] Error 2
Error: module OrcaSlicer: Child process exited with code 2
Error: Build failed: Error: The process '/usr/bin/xvfb-run' failed with exit code 1

powpingdone · 2024-07-01T06:07:01Z

You'll need to ctrl-f "error:" for the first indication of an error.

SoftFever · 2024-07-01T10:45:31Z

deps/wxWidgets/wxWidgets.cmake

@@ -26,6 +26,7 @@ orcaslicer_add_cmake_project(
    wxWidgets
    GIT_REPOSITORY "https://github.com/SoftFever/Orca-deps-wxWidgets"
    GIT_SHALLOW ON
+    GIT_TAG a675dbe8fd07cb5c982cdab7b93cffc9d9f05f22


Do we need to specify this since the a675dbe8fd07cb5c982cdab7b93cffc9d9f05f22 is the latest commit in master branch?

SoftFever · 2024-07-01T10:48:34Z

flatpak/io.github.softfever.OrcaSlicer.yml

@@ -144,7 +160,7 @@ modules:
    sources:
      - type: git
        url: https://github.com/SoftFever/Orca-deps-wxWidgets
-        branch: master
+        commit: a675dbe8fd07cb5c982cdab7b93cffc9d9f05f22 


Do we need to specify this since the a675dbe8fd07cb5c982cdab7b93cffc9d9f05f22 is the latest commit in master branch?

Yes, because they should always be the same and never mismatch during building both the appimage and flatpak. Really, it's a sanity check because of CI restrictions.

Isn't it the same if we use last master branch without pining the commit?
in case we made changes in https://github.com/SoftFever/Orca-deps-wxWidgets in the future, we don't have to modify multiple places to update it.

While it would normally, one of the things that a flathub upload would very likely require is dependency locking per release version. If a flatpak only bug is discovered, then you want to fix it without any unexpected or unneeded updates. Since this is the only dependency that has to be synchronized in a different way compared to all the other ones (due to CI size constraints), I figured this is the least intrusive method to this.

If a flatpak only bug is discovered, then you want to fix it without any unexpected or unneeded updates.

This is actually the opposite for third-party cases in my experience. It's better to avoid pointing to different commits for different build systems. The reason I'm asking to remove the commit tag is that the Orca-deps-wxWidgets repository is specifically created for OrcaSlicer. Any build break errors caused by the changes made in that repo should be promptly caught by the CI/CD pipeline.

If Flatpak points to an old commit, it will miss that check. The worst-case scenario is however that it may result in different behaviors compared to other platforms due to different versions of wxWidgets being used, which would be a nightmare to troubleshoot.

Alright, then you may revert both tagged parts.

I've reverted both tagged parts.

Sorry for the slow response.
Was a bit busy in the past two weeks.

Looks good, thank you so much!

SoftFever

Looks good
Thank you so much for the continuous effort to bring Flatpak to life!

This reverts commit 6579549.

SoftFever · 2024-07-11T13:32:19Z

@powpingdone
I noticed it causes build breaks: https://github.com/SoftFever/OrcaSlicer/actions/runs/9877669432/job/27279875122
I've temporarily reverted the change. Could you take a look when convenient?

This reverts commit e29cba2.

powpingdone added 2 commits May 30, 2024 16:58

Use fixed commit for wxwidgets

7526669

Merge remote-tracking branch 'upstream/main' into repro_build

fed36c3

powpingdone added 4 commits June 5, 2024 04:55

disable cache

d4eeab2

Merge branch 'main' into repro_build

920f9ab

Fix imports

7122727

Merge remote-tracking branch 'upstream/main' into repro_build

f216f61

revert some build stuff

d27f14d

powpingdone marked this pull request as ready for review June 6, 2024 05:40

powpingdone added 3 commits June 9, 2024 00:51

Merge branch 'main' into repro_build

1d5a0f9

Merge branch 'main' into repro_build

8ba3c61

fix python builds

e734f1a

powpingdone mentioned this pull request Jun 16, 2024

Flatpak Application TRACKING ISSUE #3949

Open

powpingdone added 2 commits June 17, 2024 01:03

Don't build OCCT docs, a constexpr borks flatpak

4615039

fix thread import

3f91db6

Merge branch 'main' into repro_build

25cdb05

Merge branch 'main' into repro_build

cc5ebcf

powpingdone added 5 commits June 22, 2024 20:21

Merge branch 'main' into repro_build

275ecf9

Fix import

e06add9

Merge branch 'main' into repro_build

a6c74b3

Fix import again

60d9354

Merge branch 'main' into repro_build

63a6d6f

Merge branch 'main' into repro_build

ea691de

powpingdone changed the title ~~Some smaller flatpak improvements~~ Some flatpak fixing Jun 30, 2024

SoftFever reviewed Jul 1, 2024

View reviewed changes

Merge branch 'main' into repro_build

f3fd65f

SoftFever force-pushed the main branch from 901d5d1 to c6205fa Compare July 1, 2024 13:56

powpingdone added 2 commits July 5, 2024 16:34

Merge remote-tracking branch 'upstream/main' into repro_build

3b6afdc

remove git commit

f05bc8e

powpingdone force-pushed the repro_build branch from 41a9630 to f05bc8e Compare July 5, 2024 19:32

SoftFever approved these changes Jul 10, 2024

View reviewed changes

SoftFever merged commit 6579549 into SoftFever:main Jul 10, 2024
16 checks passed

SoftFever added a commit that referenced this pull request Jul 11, 2024

Revert "Some flatpak fixing (#5510)"

e29cba2

This reverts commit 6579549.

powpingdone mentioned this pull request Jul 12, 2024

Try flatpak again #6119

Closed

SoftFever added a commit that referenced this pull request Jul 16, 2024

Revert "Revert "Some flatpak fixing (#5510)""

b9eaca2

This reverts commit e29cba2.

SoftFever added a commit that referenced this pull request Jul 16, 2024

Revert "Revert "Some flatpak fixing (#5510)""

002125f

This reverts commit e29cba2.

Some flatpak fixing #5510

Some flatpak fixing #5510

Conversation

powpingdone commented May 30, 2024

SoftFever commented Jun 3, 2024

powpingdone commented Jun 3, 2024

powpingdone commented Jun 3, 2024

cochcoder commented Jun 3, 2024

powpingdone commented Jun 3, 2024

powpingdone commented Jun 3, 2024

cochcoder commented Jun 3, 2024

powpingdone commented Jun 3, 2024

cochcoder commented Jun 3, 2024

powpingdone commented Jun 5, 2024 • edited Loading

cochcoder commented Jun 5, 2024

powpingdone commented Jun 6, 2024

powpingdone commented Jun 6, 2024

powpingdone commented Jun 17, 2024 • edited Loading

powpingdone commented Jun 17, 2024

cochcoder commented Jun 18, 2024

powpingdone commented Jun 18, 2024

cochcoder commented Jun 18, 2024 • edited Loading

AlessioMagni commented Jun 18, 2024

powpingdone commented Jun 19, 2024

cochcoder commented Jun 19, 2024

powpingdone commented Jun 28, 2024

cochcoder commented Jul 1, 2024 • edited Loading

powpingdone commented Jul 1, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SoftFever Jul 1, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SoftFever left a comment

Choose a reason for hiding this comment

SoftFever commented Jul 11, 2024

powpingdone commented Jun 5, 2024 •

edited

Loading

powpingdone commented Jun 17, 2024 •

edited

Loading

cochcoder commented Jun 18, 2024 •

edited

Loading

cochcoder commented Jul 1, 2024 •

edited

Loading

SoftFever Jul 1, 2024 •

edited

Loading