-
-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color fixes #5712
Color fixes #5712
Conversation
…tion and project page
Please check my tickets for ui |
@Eldenroot replied all on related tickets. let me know if there are more |
@yw4z |
@olcayoren yes i did it in previous color fixes PR but softfever requested to revert back that change |
Would be great to transfer all unmerged changes and fixes -> and merge them¨. Thank you! |
@SoftFever Hello, did it matter if the color remained orange? thnx |
@Eldenroot we are goin with baby steps instead making major changes as we discussed with @SoftFever . dont worry they are on my list. but i will try these changes with less code changes this time @olcayoren @SoftFever here is removed things from that commit. Softfever wanted to use a secondary colors on these screens because he pointed many things started to use same colors and that made things hard to pick. Decided to keeping orange color as secondary color will make things easier to pick then we didnt touched that areas I'm ok with this logic. only yellow code on gcode viewer is a bit too much for me :) |
yeah, it's less dull with accent color there ;) |
Thank you @yw4z
Other changes look good 👍 |
@SoftFever 2- i will recheck color for that and will revert that change if i cant find a better suggestion |
@kylek29 thanks for reporting. problem is i don't have a BBL printer so i can't access all BBL related UI and can't confirm my code changes correctly applied. I'm not sure is there a method for creating virtual / dummy device |
@SoftFever i reverted color change for main tab bar hovered item background color as you requested and converted this commit to ready state. i will look again for that in new color fixes commit. will open new commit when when my list has 10+ items. didnt add new items to this commit because you already checked this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yw4z
Thank you so much!
Everything looks good to me.
this commit is part 2 for color fixes. part 1 was #5239
Dark mode support for sliced plates list > plate number
problem: text is hard to read on light theme
before vs after
Flushing volumes button active state background color
left over green color from bamboo studio
before vs after
Sidebar tab button background color on light theme
left over green color from bamboo studio. visible on bbl monitor & calibration tab and project tab
before vs after
Sidebar arrow not visible
Before
After
Home page
Selected tab color on light theme
Button hover background on light theme
Context menu item hover background on light theme
Darker background for thumbnail images on dark mode
before makes you blind :)
after
Also matched colors for dark theme
Sidebar parameters group Title too bright on dark theme
Uses same color with tab text color
Sidebar > Global > Search > Dropdown list > hovered item color
Sidebar > Global > Search > Match border color with other input/combo boxes
improves visibility of border
Added descriptions to state colors
Still its mess but better than without any descriptions
Paint gizmos > remove background of non active Tool / Brush buttons on dark mode
buttons has no background on light mode. and readability improves without background
before
after
Gizmos selected text background
before
after
Keyboard shortcuts window selected tab background color
before
after
About page > link color
before
after
Project page > Add button
Project page > Return button text
before
after
Match disabled text color of combo boxes with other input boxes while disabled state
before
after
also this makes add printer window > combo boxes disabled text a bit more visible
Use better background color for disabled elements on dark mode
old color has a different tone compared to panel background. also not fits well imo
old vs new
BBL > Monitor tab > Add printer text and icon not visible on dark theme
before
after
Better background color for row highlighting on dark theme
NOTE: color not changes while switching themes. its an existing bug
used same color on sidebar titlebar background. it creates enough separation
before
after
Match style of gizmo combo boxes with regular combo box
target style
before
after
Fixed broken color changes with latest merges
Selected tab underline color