-
-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves #5808: Fix missing K1C processes #5815
Conversation
Hello! Could you provide more if a description of what is being fixed? It is not very clear with only the after screenshots. Also, when creating a PR that resolves an issue, please use a supported keyword followed by the issue number. This links the issue the the PR and automatically closes the issue when the PR is merged. Here are some details on that: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests |
Hi, I have updated the details for you. Hope this is okay. |
Oh, I'm sorry. The keyword for linking the issue should be done in the body of the PR, not the title 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
I wonder if we should rename the machine profile to include the "()" so it's consistent with K1 profiles instead? Though I guess that could cause compatibility issue for existing user. |
That was my thought @Noisyfox i wanted to cause the least chance of disruption to users |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks
Resolves #5808
Screenshots of evidance that they are now showing attatched below
Before not showing layer height profiles:
After now showing the profiles:
0.6mm Nozzle:
0.8mm Nozzle:
Update after [ee52ec3]:
0.6mm Nozzle:
0.8mm Nozzle: