Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #5808: Fix missing K1C processes #5815

Merged
merged 7 commits into from
Jun 26, 2024
Merged

Conversation

BruffyT
Copy link
Contributor

@BruffyT BruffyT commented Jun 23, 2024

Resolves #5808

Screenshots of evidance that they are now showing attatched below

Before not showing layer height profiles:

image

After now showing the profiles:

0.6mm Nozzle:

Screenshot 2024-06-23 at 14 07 16

0.8mm Nozzle:

Screenshot 2024-06-23 at 14 07 06

Update after [ee52ec3]:

0.6mm Nozzle:

Screenshot 2024-06-26 at 01 13 00

0.8mm Nozzle:

Screenshot 2024-06-26 at 01 13 14

@BruffyT BruffyT changed the title refactored printer name to resolve #5808 Refactored printer name to resolve #5808 Jun 23, 2024
@Ocraftyone
Copy link
Contributor

Hello! Could you provide more if a description of what is being fixed? It is not very clear with only the after screenshots.

Also, when creating a PR that resolves an issue, please use a supported keyword followed by the issue number. This links the issue the the PR and automatically closes the issue when the PR is merged. Here are some details on that: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests

@BruffyT BruffyT changed the title Refactored printer name to resolve #5808 Resolves #5808 Refactored printer name to resolve Jun 24, 2024
@BruffyT BruffyT changed the title Resolves #5808 Refactored printer name to resolve Resolves #5808: Refactored printer name to resolve Jun 24, 2024
@BruffyT
Copy link
Contributor Author

BruffyT commented Jun 24, 2024

Hi, I have updated the details for you. Hope this is okay.

@Ocraftyone
Copy link
Contributor

Oh, I'm sorry. The keyword for linking the issue should be done in the body of the PR, not the title 😁

Copy link
Contributor

@Ocraftyone Ocraftyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@Noisyfox
Copy link
Collaborator

I wonder if we should rename the machine profile to include the "()" so it's consistent with K1 profiles instead? Though I guess that could cause compatibility issue for existing user.

@BruffyT
Copy link
Contributor Author

BruffyT commented Jun 26, 2024

That was my thought @Noisyfox i wanted to cause the least chance of disruption to users

@SoftFever SoftFever changed the title Resolves #5808: Refactored printer name to resolve Resolves #5808: Fix missing K1C processes Jun 26, 2024
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks

@SoftFever SoftFever merged commit aeac07b into SoftFever:main Jun 26, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k1c nozzle profile dont show up.
4 participants