Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Preferences dialog sizing on multi monitor setups #5820

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

Ocraftyone
Copy link
Contributor

@Ocraftyone Ocraftyone commented Jun 23, 2024

Description

Update the way the preferences dialog size is set. Currently, on multi monitor setups, only the resolution of the main display is used, even if the window is on a different monitor with a different resolution. Now, the resolution of the monitor displaying the window is used in the sizing calculation. Also, rather than getting the total vertical resolution of the monitor, it gets the usable (or as wxWidgets calls it, the client resolution). This gets the area of the screen that does not include the task bar.

Screenshots/Recordings/Graphs

Before:
image

After:
image

Tests

Tested on Windows 11

fixes #5782

@ElectricalBoy
Copy link
Contributor

Thanks for this - would you update the description so that #5782 could be linked to this PR?

@Ocraftyone
Copy link
Contributor Author

Thanks for this - would you update the description so that #5782 could be linked to this PR?

I forgot to take a look to see if there was a related issue. Thanks!

@Jaizu
Copy link

Jaizu commented Jun 29, 2024

Why is the preferences a floating window instead its own tab/ui?

@Ocraftyone
Copy link
Contributor Author

The main reason is probably because that is how PrusaSlicer and Bambu Studio have done it and there is not really a reason to change it. Why would you want to make it a page/tab though? These settings are typically not adjusted that often, so making it a tab would just be more clutter on the top bar with little benefit.

@Jaizu
Copy link

Jaizu commented Jun 30, 2024

Because having a popup window for no reason is just ugly and annoying, doesnt cover the entire screen and its a big list. Using the entire ui would allow for better organization and less scrolling.
Super very quick and ugly mockup
image

Currently, adding settings to a big thin list makes it like a nightmare, having the size of your screen organized is a much better ux approach, is not like you want/need to see the bg of the UI while you are in preferences.

@ElectricalBoy
Copy link
Contributor

I don't really disagree with @Jaizu's idea, but I think it should be a separate FR.

@Ocraftyone
Copy link
Contributor Author

Personally, I think having it's own window is the right choice. I understand that scrolling is not ideal, but I think that should be managed with tabs like PrusaSlicer does. Having a giant wall of text I feel would be very overwhelming.

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one!
Thanks!

@SoftFever
Copy link
Owner

Displaying preferences in a modal dialog is a standard approach in desktop applications.
Showing them in a tab also makes it a bit odd from a UI/UX perspective(in the context of Orca).
All tabs in Orca are for printing-related settings and are organized with that logic, whereas software preferences are different—they are about the software itself, not the actual printing-related settings.

@SoftFever SoftFever merged commit c081267 into SoftFever:main Jul 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preferences Window Does Not Scale Properly in Multi-Monitor Setup
4 participants