-
-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Preferences dialog sizing on multi monitor setups #5820
Fix Preferences dialog sizing on multi monitor setups #5820
Conversation
Thanks for this - would you update the description so that #5782 could be linked to this PR? |
I forgot to take a look to see if there was a related issue. Thanks! |
Why is the preferences a floating window instead its own tab/ui? |
The main reason is probably because that is how PrusaSlicer and Bambu Studio have done it and there is not really a reason to change it. Why would you want to make it a page/tab though? These settings are typically not adjusted that often, so making it a tab would just be more clutter on the top bar with little benefit. |
I don't really disagree with @Jaizu's idea, but I think it should be a separate FR. |
Personally, I think having it's own window is the right choice. I understand that scrolling is not ideal, but I think that should be managed with tabs like PrusaSlicer does. Having a giant wall of text I feel would be very overwhelming. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one!
Thanks!
Displaying preferences in a modal dialog is a standard approach in desktop applications. |
Description
Update the way the preferences dialog size is set. Currently, on multi monitor setups, only the resolution of the main display is used, even if the window is on a different monitor with a different resolution. Now, the resolution of the monitor displaying the window is used in the sizing calculation. Also, rather than getting the total vertical resolution of the monitor, it gets the usable (or as wxWidgets calls it, the client resolution). This gets the area of the screen that does not include the task bar.
Screenshots/Recordings/Graphs
Before:
After:
Tests
Tested on Windows 11
fixes #5782