Duplicate Current Plate With Objects (Second PR) #6710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This the initial commit and this still needs work.
…o be updated to id=7 as we have one more plate icon. [SoftFever#2025] Removed the `printf` statements.
… when the plate is duplicated.
…tions and the toolbar.
… the `Edit` menu.
SoftFever
reviewed
Sep 10, 2024
src/slic3r/GUI/GLCanvas3D.hpp
Outdated
| @@ -159,6 +159,7 @@ wxDECLARE_EVENT(EVT_GLCANVAS_PLATE_RIGHT_CLICK, RBtnPlateEvent); | |||
| wxDECLARE_EVENT(EVT_GLCANVAS_REMOVE_OBJECT, SimpleEvent); | |||
| wxDECLARE_EVENT(EVT_GLCANVAS_ARRANGE, SimpleEvent); | |||
| //BBS: add arrange and orient event | |||
| // wxDECLARE_EVENT(EVT_GLCANVAS_DUPLICATE_PLATE, SimpleEvent); | |||
There was a problem hiding this comment.
Could we remove these unused commented codes?
SoftFever
reviewed
Sep 10, 2024
SoftFever
reviewed
Sep 10, 2024
src/slic3r/GUI/GLCanvas3D.cpp
Outdated
| @@ -6353,6 +6357,15 @@ bool GLCanvas3D::_init_main_toolbar() | |||
| if (!m_main_toolbar.add_item(item)) | |||
| return false; | |||
|
|
|||
| // item.name = "duplicateplate"; | |||
There was a problem hiding this comment.
Could we remove these unused commented codes?
There are other commentted codes, let's remove them as well
SoftFever
reviewed
Sep 10, 2024
|
Thank you, I updated my branch with your review comments. |
SoftFever
reviewed
Sep 10, 2024
SoftFever
reviewed
Sep 10, 2024
Thank you for quick response 👍 |
…duced "Duplicate Plate" functionality.
|
It should be okay now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per @SoftFever 's request here I create a new PR.
Description
Screenshots/Recordings/Graphs
Orca_Slicer_Duplicate_Plate_Preview_3_1.mp4
Tests
Run manual tests only...