The remaining time is now correctly displayed in the contest's card. #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function incorrectly converts the 'date' variable to UTC, despite it already being in UTC format. This leads to incorrect calculations. The 'date' variable does not explicitly specify its timezone (e.g., 2024-06-20T21:00:16), so calling .utc() on it shifts the time by -3 hours, resulting in an incorrect value (e.g., 2024-06-20T18:00:16). This change removes the unnecessary UTC conversion, ensuring accurate calculations.
gogo4ds
requested changes
Jun 20, 2024
gogo4ds
approved these changes
Jun 22, 2024
deyordanov
deleted the
1308-remaining-time-in-contest-cards-is-not-correct
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function incorrectly converts the 'date' variable to UTC, despite it already being in UTC format. This leads to incorrect calculations. The 'date' variable does not explicitly specify its timezone (e.g.,
2024-06-20T21:00:16), so calling.utc()on it shifts the time by -3 hours, resulting in an incorrect value (e.g.,2024-06-20T18:00:16). This change removes the unnecessary UTC conversion, ensuring accurate calculations.Closes https://github.com/SoftUni-Internal/exam-systems-issues/issues/1308