Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve links detection #376

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Improve links detection #376

merged 2 commits into from
Sep 17, 2020

Conversation

wcoder
Copy link
Member

@wcoder wcoder commented Sep 16, 2020 •
edited
Loading

Description

  • Add handle example.com, www.example.com links.

Consistently to Android: https://developer.android.com/reference/android/text/util/Linkify

API Changes

None

Platforms Affected

  • Core (all platforms)
  • iOS

PR Checklist

  • I have read the CONTRIBUTING document
  • My code follows the code styles
  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@wcoder wcoder added c/common Related to Common component. p/iOS Related to iOS platform. labels Sep 16, 2020
@wcoder wcoder added this to the vNext milestone Sep 17, 2020
@wcoder wcoder merged commit 308287f into master Sep 17, 2020
@wcoder wcoder deleted the improve/links-detection branch September 17, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SavikPavel SavikPavel SavikPavel approved these changes

@vadimpylsky vadimpylsky Awaiting requested review from vadimpylsky

@nkrisko nkrisko Awaiting requested review from nkrisko

Assignees
No one assigned
Labels
c/common Related to Common component. p/iOS Related to iOS platform.
Projects
None yet
Milestone
v2 beta 8
Development

Successfully merging this pull request may close these issues.
2 participants
@wcoder @SavikPavel