Feat/component loader #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dziraf
reviewed
Mar 27, 2023
src/log.action.ts
Outdated
| onlyForPostMethod = false, | ||
| options = {}, | ||
| }: CreateLogActionParams = {}): After<ActionResponse> => | ||
| options, |
There was a problem hiding this comment.
Why did you remove defaults here and below? 🤔
src/types.ts
Outdated
| * In case you want to use different attribute names, you can use this | ||
| * options to configure the mapping. | ||
| */ | ||
| componentLoader?: ComponentLoader; |
There was a problem hiding this comment.
Why is componentLoader optional? It should also be on different line because comment above is related to propertiesMapping prop.
added 4 commits
March 30, 2023 09:49
BREAKING CHANGE: Configuration changed due to AdminJS.bundle being removed, use componentLoader instead
dziraf
force-pushed
the
feat/component-loader
branch
from
bd09fef to
eafbb8d
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Apr 4, 2023
# [5.0.0-beta.2](v5.0.0-beta.1...v5.0.0-beta.2) (2023-04-04) ### chore * rewrite package to esmodules ([#16](#16)) ([71d2312](71d2312)) * use use componentLoader instead of AdminJS.bundle ([#17](#17)) ([3c4763c](3c4763c)) ### BREAKING CHANGES * Configuration changed due to AdminJS.bundle being removed, use componentLoader instead * The package won't support CJS anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.