Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade flask to ^2.3.0 #99

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Upgrade flask to ^2.3.0 #99

merged 2 commits into from
Jul 27, 2023

Conversation

michaelyaakoby
Copy link
Member

This required chaning the patching of jsonifying of datetime/date values to use ISO format.

As of 2.2.*, changing the datetime and date JSON encoding is done globally, see https://stackoverflow.com/a/74618781/2692895 (which is an updated reply to https://stackoverflow.com/questions/43663552/keep-a-datetime-date-in-yyyy-mm-dd-format-when-using-flasks-jsonify)

This required chaning the patching of jsonifying of datetime/date values to use ISO format.

As of 2.2.*, changing the datetime and date JSON encoding is done globally,
see https://stackoverflow.com/a/74618781/2692895 (which is an updated reply to
https://stackoverflow.com/questions/43663552/keep-a-datetime-date-in-yyyy-mm-dd-format-when-using-flasks-jsonify)
The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest),
or ubuntu-22.04 instead.
For more details see actions/runner-images#6002
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (dffb45c) 95.18% compared to head (7d2902c) 95.23%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   95.18%   95.23%   +0.05%     
==========================================
  Files          28       28              
  Lines        1163     1155       -8     
==========================================
- Hits         1107     1100       -7     
+ Misses         56       55       -1     
Files Changed Coverage Δ
pyctuator/impl/fastapi_pyctuator.py 99.01% <100.00%> (-0.03%) ⬇️
pyctuator/impl/flask_pyctuator.py 100.00% <100.00%> (+1.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelyaakoby
Copy link
Member Author

michaelyaakoby commented Jul 27, 2023

Fixes #97

@michaelyaakoby michaelyaakoby merged commit 8b78f7c into master Jul 27, 2023
2 checks passed
@michaelyaakoby michaelyaakoby deleted the michael/upgrade branch July 27, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants