Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline the usage of styles #533

Open
timea-solid opened this issue Mar 15, 2023 · 2 comments
Open

Streamline the usage of styles #533

timea-solid opened this issue Mar 15, 2023 · 2 comments
Assignees

Comments

@timea-solid
Copy link
Member

Currently there are different ways to use styles just in solid-ui
Findings after code analysis:

* all files which make use of ui style.js: infinite, message, messageTools, thread, buttons, forms, multiSelect, autocompleteField, autocompletePicker, buttons
* all files which make use of jss:acl-control, headerFooterhelpers, buttons
* all files which make use of ns.ui: participation, preferences, login, fields.stories, form.stories, options.stories, label, forms, basic, comment, fieldParams, formStyle, autocompleteField
* all files which have own styles: media, signup, dragAndDrop, error, forms, pad, participation, tabs
@timea-solid
Copy link
Member Author

In the SolidOS meeting from 15.03.2023 we have decided to go towards using only style.js throughout solid-ui and possibly leaving ns.ui only in the RDF forms part of the code and forms themselves.

@timea-solid timea-solid self-assigned this Mar 15, 2023
@timea-solid timea-solid changed the title Streamline the usage of CSS Streamline the usage of styles Apr 6, 2023
@timea-solid
Copy link
Member Author

  • JSS was refactored out ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant