-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic blackboard implementation #26
Conversation
Will try to find time to review tomorrow👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a nit comment, other than that it looks good to me :) Great work 👍 Can merge after fixing the nit comment.
Also, another nit comment:
Are you currently able to branch out from this repo? if not, let me know and I will try to fix it in the repo settings. It makes it easier to inspect / collaborate on a PR if I can just git checkout
your branch without having to clone the repo from your github.
bonsai/src/sequence.rs
Outdated
@@ -1,26 +1,39 @@ | |||
use crate::status::Status::*; | |||
use crate::{event::UpdateEvent, ActionArgs, Behavior, State, Status, RUNNING}; | |||
use std::fmt::Debug; | |||
pub struct SequenceArgs<'a, A, E, F, B> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I believe this can be private i.e remove the pub
keyword
Hey, thanks for the review! I pushed the branch to your repository, should be there as As for privating the |
@kaphula Yea, that's what I meant. Thanks! Sorry, I didn't see that it was used in another file. You can make it |
Alright, that's done. |
Generalize blackboard.
From user's perspective, in addition to being able to use generic blackboard type, the user must now use tick directly with
bt.tick(...)
instead ofbt.state.tick(...)
This change is required so that we can pass a mutable reference of the blackboard to the user's tick callback under the hood.