Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ukvm-configure expects 'blk' but Mirage uses 'block' #70

Closed
mato opened this issue Aug 9, 2016 · 1 comment
Closed

ukvm-configure expects 'blk' but Mirage uses 'block' #70

mato opened this issue Aug 9, 2016 · 1 comment
Labels
bug

Comments

@mato
Copy link
Member

mato commented Aug 9, 2016

ukvm-configure uses blk to configure a block device, but mirage is using block. For consistency with mirage-block-solo5 I propose to rename the ukvm-blk module to ukvm-block. Plus, there's no need to save a character.
@mato mato added the bug label Aug 9, 2016
@mato mato mentioned this issue Aug 9, 2016
Closed
mato added a commit to mato/mirage that referenced this issue Aug 9, 2016
@mato
ukvm target: Correct use of "blk" for block module
0a93185 
Fixes Solo5/solo5#70 (easier doing it here than the other way round) and
mirage/mirage-skeleton#178.
@mato mato mentioned this issue Aug 9, 2016
Merged
@mato
Copy link
Member Author

mato commented Aug 10, 2016

Fixed via mirage/mirage#576.

@mato mato closed this as completed Aug 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mato