Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book Text Utils #72

Merged
merged 89 commits into from
Feb 14, 2021
Merged

Book Text Utils #72

merged 89 commits into from
Feb 14, 2021

Conversation

jcxldn
Copy link
Member

@jcxldn jcxldn commented Jan 17, 2021

14/2/21 | JCX's To-Do List*

  • Split gradle changes? (eg. javadoc stuffs)
  • Split OnHold annotation (master?)
  • Address minor review requests
  • Split UtilityClass annotations for unaffected files?

@codecov
Copy link

codecov bot commented Jan 17, 2021

Codecov Report

Merging #72 (4003bae) into master (6392053) will increase coverage by 2.87%.
The diff coverage is 37.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #72      +/-   ##
============================================
+ Coverage     20.31%   23.19%   +2.87%     
- Complexity      133      181      +48     
============================================
  Files            71       73       +2     
  Lines          3012     3126     +114     
  Branches        402      426      +24     
============================================
+ Hits            612      725     +113     
+ Misses         2379     2355      -24     
- Partials         21       46      +25     
Impacted Files Coverage Δ Complexity Δ
...umbdogdiner/stickyapi/common/util/url/URLPair.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...m/dumbdogdiner/stickyapi/common/util/TextUtil.java 30.30% <28.12%> (+30.30%) 5.00 <5.00> (+5.00)
...ner/stickyapi/bukkit/item/BookAndQuillBuilder.java 28.57% <28.57%> (ø) 6.00 <6.00> (?)
...iner/stickyapi/bukkit/item/WrittenBookBuilder.java 33.87% <33.87%> (ø) 7.00 <7.00> (?)
...m/dumbdogdiner/stickyapi/common/util/MathUtil.java 25.00% <40.00%> (+11.20%) 7.00 <3.00> (+3.00)
...dumbdogdiner/stickyapi/common/util/StringUtil.java 94.93% <83.33%> (-1.79%) 36.00 <6.00> (+7.00) ⬇️
...bdogdiner/stickyapi/common/nbt/NbtJsonAdapter.java 12.50% <0.00%> (+12.50%) 1.00% <0.00%> (+1.00%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6392053...4003bae. Read the comment docs.

@jcxldn jcxldn marked this pull request as ready for review January 17, 2021 09:25
@jcxldn jcxldn requested a review from ZachyFoxx January 17, 2021 09:26
@SolteraGG SolteraGG deleted a comment from ZachyFoxx Feb 14, 2021
@SolteraGG SolteraGG deleted a comment from ZachyFoxx Feb 14, 2021
@SolteraGG SolteraGG deleted a comment from ZachyFoxx Feb 14, 2021
Copy link
Member Author

@jcxldn jcxldn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aakatz3
Copy link
Collaborator

aakatz3 commented Feb 14, 2021 via email

@jcxldn jcxldn merged commit 9fbcedf into master Feb 14, 2021
@jcxldn jcxldn deleted the fixup/book-text-utils branch February 14, 2021 16:15
jcxldn added a commit that referenced this pull request Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request non-breaking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants