Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

properly encode strings when using cfg format #116

Merged
merged 11 commits into from
Feb 26, 2019
Merged

properly encode strings when using cfg format #116

merged 11 commits into from
Feb 26, 2019

Conversation

omerlh
Copy link
Contributor

@omerlh omerlh commented Feb 26, 2019 •
edited
Loading

close #117

shaikatz
shaikatz reviewed Feb 26, 2019
View reviewed changes
init-container/index.js Outdated Show resolved Hide resolved
@shaikatz @omerlh
Update init-container/index.js
684d291 
Co-Authored-By: omerlh <omerlh@users.noreply.github.com>
shaikatz
shaikatz reviewed Feb 26, 2019
View reviewed changes
init-container/index.js Outdated Show resolved Hide resolved
@shaikatz @omerlh
Update init-container/index.js
b1a5441 
thanks! I noticed that last time :facepalm

Co-Authored-By: omerlh <omerlh@users.noreply.github.com>
shaikatz
shaikatz suggested changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@shaikatz shaikatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

shaikatz and others added 5 commits February 26, 2019 14:33
shaikatz
shaikatz reviewed Feb 26, 2019
View reviewed changes
init-container/README.md Outdated
| `-f/--output-format <format>` | false | The format of the output file, default to JSON. Supported types: json, cfg, cfg-strict (escape strings), files | JSON |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not exactly escape string, it's to surround strings with quotation marks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, doesn't need to write that it defaults to JSON since we have the default value column.

shaikatz
shaikatz previously approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@shaikatz shaikatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just check my last comment and see if you think it's relevant.

@omerlh omerlh merged commit 9d69395 into master Feb 26, 2019
@omerlh omerlh deleted the cfg_string branch February 26, 2019 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaikatz shaikatz shaikatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

String not formatted properly when using cfg format
2 participants
@omerlh @shaikatz