Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invoices error report #26

Merged
merged 8 commits into from
May 22, 2024
Merged

Fix invoices error report #26

merged 8 commits into from
May 22, 2024

Conversation

javikalsan
Copy link
Contributor

Description

Handle properly timeout error at client side generating invoices zip file

Changes

  • Custom timeout for some ERP queries
  • Report invoice zip timeout
  • Single zip for many invoices

Checklist

Justify any unchecked point:

  • Changed code is covered by tests.
  • Relevant changes are explained in the "Unreleased" section of the CHANGES.md file.
  • That section includes "Upgrade notes" with any config, dependency or deploy tweek needed on development and server setups.
    N/A
  • Changes on the setup process (development, testing, production) have been updated in the proper documentation
    N/A

Observations

N/A

Please, review

  • Via tests and manually interacting with the application invoice list and zip file generations are working as expected.

How to check the new features

Manually

  • Set up a timeout of 0.1 for zip file generation endpoint for example to force a timeout and review the error information is setting up properly at download button and at the snack bar error messages

Deploy notes

N/A

javikalsan and others added 8 commits May 21, 2024 14:37
Co-authored-by: David García Garzón <david.garcia@somenergia.coop>
Co-authored-by: David García Garzón <david.garcia@somenergia.coop>
Co-authored-by: David García Garzón <david.garcia@somenergia.coop>
Co-authored-by: David García Garzón <david.garcia@somenergia.coop>
Co-authored-by: David García Garzón <david.garcia@somenergia.coop>
Co-authored-by: David García Garzón <david.garcia@somenergia.coop>
As we handle timeouts, set specific bigger timeout for zip download,
and show a proper message in zip download timeout,
we can now download all pdfs in a single zip.

Co-authored-by: David García Garzón <david.garcia@somenergia.coop>
Co-authored-by: David García Garzón <david.garcia@somenergia.coop>
Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@javikalsan javikalsan added the show Reviews are wellcome but won't block integration label May 22, 2024
@javikalsan javikalsan assigned javikalsan and vokimon and unassigned vokimon and javikalsan May 22, 2024
@javikalsan javikalsan merged commit a7f8fb4 into main May 22, 2024
5 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 9187547152

Details

  • 11 of 15 (73.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 64.479%

Changes Missing Coverage Covered Lines Changed/Added Lines %
backend/api_business.py 3 5 60.0%
backend/erp.py 8 10 80.0%
Totals Coverage Status
Change from base Build 9171505738: -0.003%
Covered Lines: 546
Relevant Lines: 793

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
show Reviews are wellcome but won't block integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants