Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve semantics of Summary generic for soma_adat class #121

Closed
stufield opened this issue Apr 23, 2024 · 0 comments
Closed

Improve semantics of Summary generic for soma_adat class #121

stufield opened this issue Apr 23, 2024 · 0 comments
Labels
feature New feature or request

Comments

@stufield
Copy link
Contributor

  • originally borrowed from Summary.data.frame(), but not ideal for soma_adat class.
  • refactor to make more appropriate

Thanks for contributing 🥳!
@stufield stufield added the feature New feature or request label Apr 23, 2024
stufield added a commit to scheidec/SomaDataIO that referenced this issue Apr 24, 2024
@stufield
Fixed bug in Summary.soma_adat() operations
895f3ca 
- these operations: min(), max(), any(), range(), etc.
- would return the incorrect value due to
  an `as.matrix()` conversion under the hood
- now skips that conversion, trips a warning,
  and carries on
- triggers an error of non-numerics are passed
  as part of the '...' outside of a `soma_adat`,
  just like `Summary.data.frame()`
- fixes SomaLogic#121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stufield