Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop is_intact_attr() from bubbling up messages deep in the call stack #71

Closed
stufield opened this issue Jan 5, 2024 · 0 comments · Fixed by #74
Closed

Stop is_intact_attr() from bubbling up messages deep in the call stack #71

stufield opened this issue Jan 5, 2024 · 0 comments · Fixed by #74

Comments

@stufield
Copy link
Contributor

stufield commented Jan 5, 2024

This is an internal feature that may affect downstream users who incorporate SomaDataIO into their own packages.

Currently is_intact_attr() will report failed attributes calls to the console, even from deep within the call stack.

This is likely unintended, the likely desired behavior is to have the console reporting only for direct calls to is_intact_attr().
stufield added a commit to stufield/SomaDataIO that referenced this issue Jan 5, 2024
@stufield
Silence is_intact_attr() signaling when called indirectly
66828f7 
- added new conditional logic to silence
  signaling messages when `is_intact_attr()`
  is called from within another function (indirectly)
- these messages can be confusing to the
  user when they appear in wrapper functions,
  where `is_intact_attr()` is (sometimes deeply) nested
- fixes SomaLogic#71
@stufield stufield mentioned this issue Jan 5, 2024
Merged
stufield added a commit that referenced this issue Jan 5, 2024
@stufield
Silence is_intact_attr() signaling when called indirectly
9c63813 
- added new conditional logic to silence
  signaling messages when `is_intact_attr()`
  is called from within another function (indirectly)
- these messages can be confusing to the
  user when they appear in wrapper functions,
  where `is_intact_attr()` is (sometimes deeply) nested
- fixes #71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Silence is_intact_attr() signaling when called indirectly stufield/SomaDataIO
1 participant
@stufield