New grouped_df class support with soma_adat objects
#67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 73.64% 73.88% +0.23%
==========================================
Files 39 39
Lines 1442 1455 +13
==========================================
+ Hits 1062 1075 +13
Misses 380 380 ☔ View full report in Codecov by Sentry. |
stufield
force-pushed
the
add-grouped-df-support
branch
3 times, most recently
from
499e140
to
63078e6
Compare
amanda-hi
reviewed
Jan 8, 2024
amanda-hi
reviewed
Jan 8, 2024
- grouped_df data objects were interfering with the S3 methods for dplyr verbs of the `soma_adat` class once `NextMethod()` was called - this support now ensures that the group methods are maintained, as well as the `soma_adat` class itself (with its attributes) - fixes SomaLogic#66
- now displays Group information from a call to the S3 print method
- this method is invoked on `rownmaes()` calls to the `soma_adat` class. - Rather than calling `NextMethod()` which normally would invoke `data.frame`, we now force the `data.frame` method in case there are `tbl_df` or `grouped_df` classes present that would be dispatched. Those are bypassed in favor of the `data.frame` because `tbl_df` 1) can nuke the attributes, 2) triggers a warning about adding rownames to a `tibble`
- now uses internal functions with each other as originally intended to avoid redundency
- no need for retro-update-pkgdown.sh
stufield
force-pushed
the
add-grouped-df-support
branch
from
e0e5e51
to
bc418bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of Pull Request
Adding new
grouped_dfsupport for thesoma_adatclass.The combination of
soma_adat,grouped_dfwas interfering with class reconstitution of attrs.Needed to make the underlying S3 methods more robust to
NextMethod()calls.No user facing changes (beyond bug-fix), except for the S3 print method for
grouped_dfsoma_adats.Fixes #66
Main changes
dplyrS3 method verbsgrouped_dfsupport (thesoma_adatclass is maintained)c("soma_adat", "grouped_df")classrow.names<-.soma_adat()method, that is essentially apass thru to the
data.framemethod that ensures no inherited classdispatch happens (e.g.
tbl_df) ... bypassing the rownames warning on tibbles..soma_adat_restore(),.sort_attrs()for thedplyrverb suite[extract method forsoma_adat, for the edge-case ofgrouped_dfsoma_adats.Change type
Please check the relevant box(es):
Choose reviewer(s)
Code
This should now work: