This repository has been archived by the owner on Oct 3, 2024. It is now read-only.
Increase node version on release from Node 12 -> 18 #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zglicz
requested review from
vdiez,
julien-carsique-sonarsource and
ericmorand-sonarsource
|
ericmorand-sonarsource
approved these changes
May 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ESLINTJS-39
With the updates to the packages we use, running a release fails - https://github.com/SonarSource/eslint-plugin-sonarjs/actions/runs/8936694762 .
Husky v9.0.11 requires Node >= 18, let us increase it to try.
Adding @julien-carsique-sonarsource - as you already looked at our pipelines before on https://sonarsource.atlassian.net/browse/BUILD-4742 . I'm not sure how to test this change other than testing in production. In the ticket, you mention all of the steps that we are using in jfrog are also deprecated, so maybe it would be a good time to update them?