Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify rule S6964: Update message and description #3942

Merged
merged 3 commits into from
May 27, 2024

Conversation

mary-georgiou-sonarsource
Copy link
Contributor

No description provided.

Copy link
Contributor

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left one comment that should be addressed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one more thing that should be mentioned (which I should have added before merging the rule): the analyzer will only raise for Model classes that are in the same project as the Controller class that references them. This is due to a limitation of Roslyn (see this issue), something that we can't handle right now, but it should be mentioned in the RSPEC.

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@mary-georgiou-sonarsource mary-georgiou-sonarsource merged commit 3b522aa into master May 27, 2024
10 of 11 checks passed
@mary-georgiou-sonarsource mary-georgiou-sonarsource deleted the mary/update-S6964 branch May 27, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants