Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S6932 FP: IFormCollection.Files access should be compliant #9344

Closed
martin-strecker-sonarsource opened this issue May 27, 2024 · 0 comments · Fixed by #9352
Closed

Fix S6932 FP: IFormCollection.Files access should be compliant #9344

martin-strecker-sonarsource opened this issue May 27, 2024 · 0 comments · Fixed by #9352
Assignees
@zsolt-kolbay-sonarsource
Labels
Area: C# C# rules related issues. Sprint: Hardening Fix FPs/FNs/improvements Type: False Positive Rule IS triggered when it shouldn't be.

Comments

@martin-strecker-sonarsource
Copy link
Contributor

martin-strecker-sonarsource commented May 27, 2024 •
edited
Loading

Description

[HttpPost]
public IActionResult SomeAction(IFormCollection formCollection)
{
    var files = formCollection.Files; // Noncompliant FP
    // ..
}

We recommend using IFormCollection for binding in the RSpec of S6932. formCollection.Files should therefore also be compliant.
@martin-strecker-sonarsource martin-strecker-sonarsource added Type: False Positive Rule IS triggered when it shouldn't be. Area: C# C# rules related issues. Sprint: Hardening Fix FPs/FNs/improvements labels May 27, 2024
Merged
martin-strecker-sonarsource added a commit that referenced this issue May 29, 2024
@martin-strecker-sonarsource
Fix #9344
719e164
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource

Labels
Area: C# C# rules related issues. Sprint: Hardening Fix FPs/FNs/improvements Type: False Positive Rule IS triggered when it shouldn't be.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix S6932 FP: IFormCollection.Files access should be compliant SonarSource/sonar-dotnet
2 participants
@martin-strecker-sonarsource @zsolt-kolbay-sonarsource