Set up CI with Azure Pipelines #2826

costin-zaharia-sonarsource · 2019-11-25T15:07:30Z

costin-zaharia-sonarsource · 2019-12-06T14:49:37Z

sonaranalyzer-dotnet/its/sources/AutoMapper/src/AutoMapper/AutoMapper.csproj

@@ -19,6 +19,7 @@
    <AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
    <CodeAnalysisRuleSet>..\..\..\..\ValidationRuleset.ruleset</CodeAnalysisRuleSet>
    <ProjectGuid>025B9F93-7953-454B-AF29-E6A55B2AA58F</ProjectGuid>
+    <DisableImplicitNuGetFallbackFolder>true</DisableImplicitNuGetFallbackFolder>


This was needed due to this issue: NuGet/Home#7414

costin-zaharia-sonarsource · 2019-12-06T14:50:23Z

sonaranalyzer-dotnet/src/SonarAnalyzer.RuleDescriptorGenerator/packages.lock.json

@@ -0,0 +1,409 @@
+{


The packages.lock.json files were generated to enable caching on azure pipelines

azure-pipelines.yml

andrei-epure-sonarsource · 2019-12-06T15:15:43Z

azure-pipelines.yml

+stages:
+- template: stage-with-burgr-notifications.yml@commonTemplates
+  parameters:
+    burgrName: 'build'


@tomverin - are these names predefined or can we give custom names? it would be more readable to be analyzer build inside burgr

azure-pipelines.yml

its/src/test/java/com/sonar/it/csharp/CoverageTest.java

andrei-epure-sonarsource · 2019-12-06T15:26:49Z

its/src/test/java/com/sonar/it/csharp/MetricsIncludeHeaderCommentTest.java

@@ -110,17 +115,17 @@ public void projectIsAnalyzed() {

  @Test
  public void linesAtProjectLevel() {
-    assertThat(getProjectMeasureAsInt("lines")).isEqualTo(117);
+    assertThat(getProjectMeasureAsInt("lines")).isEqualTo(118);


note: this test MetricsIncludeHeaderCommentTest.java was not being run before on the QA (when I added it 6 months ago I forgot to update Tests.java). These metrics are the same with the ones in Metrics.java.

So these changes are fine

andrei-epure-sonarsource · 2019-12-06T15:27:47Z

its/src/test/java/com/sonar/it/csharp/Tests.java

@@ -46,6 +46,7 @@
  CasingAppTest.class,
  CoverageTest.class,
  DoNotAnalyzeTestFilesTest.class,
+  MetricsIncludeHeaderCommentTest.class,


this wasn't run before on QA

its/src/test/java/com/sonar/it/vbnet/DoNotAnalyzeTestFilesTest.java

andrei-epure-sonarsource · 2019-12-06T16:08:45Z

...red-library/src/test/java/org/sonar/plugins/dotnet/tests/CoverageReportImportSensorTest.java

+      String vstsSourcePath = VstsUtils.getSourcesDirectory();
+      baseDirectory = new File(vstsSourcePath);
+    }
+    TemporaryFolder folder = new TemporaryFolder(baseDirectory);


could directly return this

andrei-epure-sonarsource · 2019-12-06T16:09:45Z

...er-dotnet/its/expected/Automapper/AutoMapper-025B9F93-7953-454B-AF29-E6A55B2AA58F-S1200.json

@@ -2,7 +2,7 @@
 "issues":  [
 {
 "id":  "S1200",
-"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 33 to the maximum authorized 30 or less.",
+"message":  "Split this class into smaller and more specialized ones to reduce its dependencies on other classes from 34 to the maximum authorized 30 or less.",


this is related to #2854

andrei-epure-sonarsource · 2019-12-06T16:12:37Z

sonaranalyzer-dotnet/tests/SonarAnalyzer.UnitTest/Performance/PerformanceTests.cs

@@ -50,6 +50,7 @@ public class PerformanceTests
        // dotnet test or vstest.console.exe: pass the following command line argument
        //       --TestCaseFilter:"TestCategory!=Slow"
        [TestCategory("Slow")]
+        [Ignore("Skip this one as it adds significant delays. It will be moved to the integration tests.")]


related to #2578

andrei-epure-sonarsource

almost there

andrei-epure-sonarsource · 2019-12-06T16:14:19Z

@christophe-zurn-sonarsource - most of the thousands of lines of code are actually auto-generated json files needed by nuget caching (and they're at the end of the PR list), so it's not that bad as review experience

andrei-epure-sonarsource

LGTM

christophe-zurn-sonarsource · 2019-12-09T09:59:20Z

azure-pipelines.yml

+        displayName: 'Run Code Analysis - End Step'
+
+      - task: SonarCloudPublish@1
+        displayName: 'Run Code Analysis - Publish QG'


FYI, the QG tab on burgr is missing for the new pipeline

Hi @tomverin, do you know why the QG is missing?

Ok, I've found out. When executing the SonarCloudPrepare task we have to specify the analysis parameters. These will be sent later to burgr to display the Quality Gate.

I've added a few commits with the required changes.

christophe-zurn-sonarsource · 2019-12-09T10:01:05Z

azure-pipelines.yml

+          sqMavenPluginVersionChoice: 'latest'
+
+      - task: SonarCloudPublish@1
+        displayName: 'Run Code Analysis - Publish QG'


We have 2 SonarCloudPublish in the yml file. From our discussion, I get that we mostly care about .NET SonarAnalyzer QG, however, are we sure that it is always the correct QG that will be published to github ?

Very good question. Due to a SonarCloud/Qube limitation, currently, only one QG is displayed on GitHub; the one which completes the last (it overwrites all the previous ones).

Since the .Net unit tests take longer that java ones (with about 4 minutes difference) their result will be the one displayed. This is a happy coincidence since this is what we want to display.

I think this could be good enough for now until the cloud team will address that limitation. What to you think?

I think we should have a ticket to track this.
Do you know if the sonarcloud team is actively working to fix this?

(address code review comments)

- the dependencies are defined with stageDependencies

- in order to match burger commit id

- was added for debugging purposes

andrei-epure-sonarsource

LGTM

christophe-zurn-sonarsource

LGTM !

costin-zaharia-sonarsource force-pushed the costin/azure-pipelines branch 9 times, most recently from 2704832 to ac9b647 Compare November 26, 2019 12:30

andrei-epure-sonarsource mentioned this pull request Nov 26, 2019

[DO NOT MERGE] Test Azure Piplines PR ccov #2835

Closed

costin-zaharia-sonarsource force-pushed the costin/azure-pipelines branch 3 times, most recently from 477fbdf to 93c19e8 Compare November 26, 2019 15:11

andrei-epure-sonarsource mentioned this pull request Dec 6, 2019

Migrate CI to Azure Pipelines #2834

Closed

26 tasks

costin-zaharia-sonarsource force-pushed the costin/azure-pipelines branch from 91149a2 to 80efda1 Compare December 6, 2019 14:14

Move the build to Azure pipelines

6312349

costin-zaharia-sonarsource force-pushed the costin/azure-pipelines branch from 80efda1 to 6312349 Compare December 6, 2019 14:40

costin-zaharia-sonarsource commented Dec 6, 2019

View reviewed changes

costin-zaharia-sonarsource requested review from andrei-epure-sonarsource and christophe-zurn-sonarsource December 6, 2019 15:12

andrei-epure-sonarsource reviewed Dec 6, 2019

View reviewed changes

andrei-epure-sonarsource requested changes Dec 6, 2019

View reviewed changes

costin-zaharia-sonarsource added 2 commits December 6, 2019 17:19

Update display names for azure tasks

5644f49

Remove verbose logging

0e1b22c

costin-zaharia-sonarsource requested a review from andrei-epure-sonarsource December 6, 2019 16:25

andrei-epure-sonarsource requested a review from tomverin December 9, 2019 08:03

andrei-epure-sonarsource approved these changes Dec 9, 2019

View reviewed changes

tomverin approved these changes Dec 9, 2019

View reviewed changes

christophe-zurn-sonarsource reviewed Dec 9, 2019

View reviewed changes

Remove unnecessary variable

fb227f3

(address code review comments)

costin-zaharia-sonarsource force-pushed the costin/azure-pipelines branch 2 times, most recently from e53b68b to fb227f3 Compare December 9, 2019 13:04

Remove invalid dependsOn

b1967a9

- the dependencies are defined with stageDependencies

costin-zaharia-sonarsource force-pushed the costin/azure-pipelines branch from ddfac7d to b1967a9 Compare December 9, 2019 14:18

costin-zaharia-sonarsource and others added 3 commits December 9, 2019 15:34

Regenerate packages.lock.json files

5f83fba

Try to fix burgr integration

4ff783f

Add analysis properties

ab91a1c

costin-zaharia-sonarsource force-pushed the costin/azure-pipelines branch 2 times, most recently from 9a90c26 to 3fd3c2e Compare December 10, 2019 08:27

Display environment variables

7e694cb

costin-zaharia-sonarsource force-pushed the costin/azure-pipelines branch from 3fd3c2e to 7e694cb Compare December 10, 2019 08:42

costin-zaharia-sonarsource and others added 5 commits December 10, 2019 10:44

Use SourceCommitId as sha1

9bebb53

- in order to match burger commit id

Temporary disable integration tests

797aa53

Set different parameters for PR or branch

2aa58d2

Enable integration tests

e7ee38d

Remove powershell task

5ceafbf

- was added for debugging purposes

andrei-epure-sonarsource approved these changes Dec 10, 2019

View reviewed changes

costin-zaharia-sonarsource requested a review from christophe-zurn-sonarsource December 10, 2019 11:03

christophe-zurn-sonarsource approved these changes Dec 10, 2019

View reviewed changes

costin-zaharia-sonarsource merged commit 9b5c5bd into master Dec 10, 2019

costin-zaharia-sonarsource deleted the costin/azure-pipelines branch December 10, 2019 13:27

andrei-epure-sonarsource mentioned this pull request Dec 11, 2019

Repox burgr azure #2847

Closed

andrei-epure-sonarsource mentioned this pull request Jul 19, 2021

[Infra] Document and clean up CI build scripts #2264

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set up CI with Azure Pipelines #2826

Set up CI with Azure Pipelines #2826

costin-zaharia-sonarsource commented Nov 25, 2019 •

edited by andrei-epure-sonarsource

Loading

costin-zaharia-sonarsource Dec 6, 2019

costin-zaharia-sonarsource Dec 6, 2019

andrei-epure-sonarsource Dec 6, 2019

andrei-epure-sonarsource Dec 6, 2019

andrei-epure-sonarsource Dec 6, 2019

andrei-epure-sonarsource Dec 6, 2019

andrei-epure-sonarsource Dec 6, 2019

andrei-epure-sonarsource Dec 6, 2019

andrei-epure-sonarsource left a comment

andrei-epure-sonarsource commented Dec 6, 2019

andrei-epure-sonarsource left a comment

christophe-zurn-sonarsource Dec 9, 2019 •

edited

Loading

costin-zaharia-sonarsource Dec 9, 2019

costin-zaharia-sonarsource Dec 10, 2019

christophe-zurn-sonarsource Dec 9, 2019

costin-zaharia-sonarsource Dec 9, 2019 •

edited

Loading

andrei-epure-sonarsource Dec 10, 2019

andrei-epure-sonarsource left a comment

christophe-zurn-sonarsource left a comment

Set up CI with Azure Pipelines #2826

Set up CI with Azure Pipelines #2826

Conversation

costin-zaharia-sonarsource commented Nov 25, 2019 • edited by andrei-epure-sonarsource Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrei-epure-sonarsource left a comment

Choose a reason for hiding this comment

andrei-epure-sonarsource commented Dec 6, 2019

andrei-epure-sonarsource left a comment

Choose a reason for hiding this comment

christophe-zurn-sonarsource Dec 9, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

costin-zaharia-sonarsource Dec 9, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrei-epure-sonarsource left a comment

Choose a reason for hiding this comment

christophe-zurn-sonarsource left a comment

Choose a reason for hiding this comment

costin-zaharia-sonarsource commented Nov 25, 2019 •

edited by andrei-epure-sonarsource

Loading

christophe-zurn-sonarsource Dec 9, 2019 •

edited

Loading

costin-zaharia-sonarsource Dec 9, 2019 •

edited

Loading