Incremental PR analysis: Implement HashProvider #6506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costin-zaharia-sonarsource
force-pushed
the
costin/file-hash
branch
from
8b92042
to
9bc5eda
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
Kudos, SonarCloud Quality Gate passed!
|
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned costin-zaharia-sonarsource
pavel-mikula-sonarsource
approved these changes
Dec 8, 2022
| import java.security.NoSuchAlgorithmException; | ||
|
|
||
| public class HashProvider { | ||
| public byte[] computeHash(Path filePath) throws NoSuchAlgorithmException, IOException { |
There was a problem hiding this comment.
Open question: Isn't this one going to make our life easier?
Suggested change
| public byte[] computeHash(Path filePath) throws NoSuchAlgorithmException, IOException { | |
| public byte[] computeHash(Path filePath) throws Throwable { |
There was a problem hiding this comment.
With this the contract is clear. We say exactly what kind of exceptions we throw.
When handling the exception can use the base type Throwable or Exception or even be explicit, depending on the needs.
github-actions
bot
assigned costin-zaharia-sonarsource and unassigned pavel-mikula-sonarsource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6486