-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incremental PR Analysis: Populate the cache #6507
Merged
costin-zaharia-sonarsource
merged 4 commits into
master
from
costin/FileStatusCacheSensor
Dec 9, 2022
Merged
Incremental PR Analysis: Populate the cache #6507
costin-zaharia-sonarsource
merged 4 commits into
master
from
costin/FileStatusCacheSensor
Dec 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
costin-zaharia-sonarsource
force-pushed
the
costin/FileStatusCacheSensor
branch
from
December 8, 2022 09:18
c1943e1
to
d6888b9
Compare
costin-zaharia-sonarsource
force-pushed
the
costin/FileStatusCacheSensor
branch
5 times, most recently
from
December 8, 2022 11:15
8feec0e
to
6979a0f
Compare
pavel-mikula-sonarsource
requested changes
Dec 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor stuff, mostly logging and names
...library/src/main/java/org/sonarsource/dotnet/shared/plugins/AbstractPropertyDefinitions.java
Outdated
Show resolved
Hide resolved
...hared-library/src/main/java/org/sonarsource/dotnet/shared/plugins/FileStatusCacheSensor.java
Outdated
Show resolved
Hide resolved
...hared-library/src/main/java/org/sonarsource/dotnet/shared/plugins/FileStatusCacheSensor.java
Outdated
Show resolved
Hide resolved
...hared-library/src/main/java/org/sonarsource/dotnet/shared/plugins/FileStatusCacheSensor.java
Outdated
Show resolved
Hide resolved
...hared-library/src/main/java/org/sonarsource/dotnet/shared/plugins/FileStatusCacheSensor.java
Outdated
Show resolved
Hide resolved
...hared-library/src/main/java/org/sonarsource/dotnet/shared/plugins/FileStatusCacheSensor.java
Outdated
Show resolved
Hide resolved
...hared-library/src/main/java/org/sonarsource/dotnet/shared/plugins/FileStatusCacheSensor.java
Outdated
Show resolved
Hide resolved
...d-library/src/test/java/org/sonarsource/dotnet/shared/plugins/FileStatusCacheSensorTest.java
Outdated
Show resolved
Hide resolved
...d-library/src/test/java/org/sonarsource/dotnet/shared/plugins/FileStatusCacheSensorTest.java
Outdated
Show resolved
Hide resolved
...d-library/src/test/java/org/sonarsource/dotnet/shared/plugins/FileStatusCacheSensorTest.java
Outdated
Show resolved
Hide resolved
costin-zaharia-sonarsource
force-pushed
the
costin/FileStatusCacheSensor
branch
from
December 9, 2022 10:28
1c0f64b
to
6700ba6
Compare
pavel-mikula-sonarsource
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...tnet-shared-library/src/main/java/org/sonarsource/dotnet/shared/plugins/FileCacheSensor.java
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6486